Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: use fonctional args for Issue and Sign #15

Merged
merged 6 commits into from Apr 4, 2019

Conversation

Projects
None yet
1 participant
@primalmotion
Copy link
Member

primalmotion commented Apr 4, 2019

This pr deprecated IssueCertificates and SignCSR in favor or Issue and Sign. The laters use functional arguments to make usage way easier. Options allows fine tuning as before, or provides high level versions that makes configuration easy.

@primalmotion primalmotion changed the title reorg code new: use fonctional args for Issue and Sign Apr 4, 2019

@primalmotion

This comment has been minimized.

Copy link
Member Author

primalmotion commented Apr 4, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "better-tg",
    "component": "tg",
    "pr-id": "15",
    "commit-sha": "96f3314f9dae003f55b5135aaea3ad461e361fbc"
  },
  {
    "project": "better-tg",
    "component": "backend",
    "pr-id": "345",
    "commit-sha": "9f7821dd12faeb8549242618c9400ca86b80b2ef"
  }
]
@primalmotion

This comment has been minimized.

Copy link
Member Author

primalmotion commented Apr 4, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "better-tg",
    "component": "tg",
    "pr-id": "15",
    "commit-sha": "9fe124917983a0784bb53bb4096445f78b22a8e8"
  },
  {
    "project": "better-tg",
    "component": "backend",
    "pr-id": "345",
    "commit-sha": "1e62067565e5ca9b841171fd5e02a1a2f6e2194b"
  }
]
@primalmotion

This comment has been minimized.

Copy link
Member Author

primalmotion commented Apr 4, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "better-tg",
    "component": "tg",
    "pr-id": "15",
    "commit-sha": "897f82e177efa9e76ecad464f49e63970c9f9fbd"
  },
  {
    "project": "better-tg",
    "component": "backend",
    "pr-id": "345",
    "commit-sha": "1e62067565e5ca9b841171fd5e02a1a2f6e2194b"
  }
]
@primalmotion

This comment has been minimized.

Copy link
Member Author

primalmotion commented Apr 4, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "better-tg",
    "component": "tg",
    "pr-id": "15",
    "commit-sha": "d3d6cd28b64d5720fd3f1a22966cdb42c35a4bce"
  },
  {
    "project": "better-tg",
    "component": "backend",
    "pr-id": "345",
    "commit-sha": "1e62067565e5ca9b841171fd5e02a1a2f6e2194b"
  }
]
@primalmotion

This comment has been minimized.

Copy link
Member Author

primalmotion commented Apr 4, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "better-tg",
    "component": "backend",
    "pr-id": "345",
    "commit-sha": "1e62067565e5ca9b841171fd5e02a1a2f6e2194b"
  },
  {
    "project": "better-tg",
    "component": "tg",
    "pr-id": "15",
    "commit-sha": "dd0ba01cd6f236c767f6cb5c08e6e51bdbd05140"
  }
]
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #15 into master will decrease coverage by 1.76%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #15      +/-   ##
=========================================
- Coverage   48.47%   46.7%   -1.77%     
=========================================
  Files           2       2              
  Lines         491     471      -20     
=========================================
- Hits          238     220      -18     
+ Misses        220     218       -2     
  Partials       33      33
Impacted Files Coverage Δ
tgnoob/helpers.go 37.77% <96%> (-3.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9813b...dd0ba01. Read the comment docs.

@primalmotion primalmotion merged commit 3a02e3d into master Apr 4, 2019

6 checks passed

built
Details
codecov/patch 96% of diff hit (target 48.47%)
Details
codecov/project Absolute coverage decreased by -1.76% but relative coverage increased by +47.52% compared to 6131f14
Details
functional-tests Submitter: reason: . functional-tests set to success
Details
functional-tests-trigger Submitter: reason: . functional-tests-trigger set to success
Details
unit-tests
Details

@primalmotion primalmotion deleted the better-tg branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.