Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix golang windows cert store bug - need to check list of RootCAs plu… #20

Merged
merged 1 commit into from Mar 25, 2020

Conversation

@philipatl
Copy link
Contributor

philipatl commented Mar 25, 2020

…s allow Windows APIs to be called to dynamically load root CA if necessary

…s allow Windows APIs to be called to dynamically load root CA if necessary
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #20 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   44.55%   44.55%           
=======================================
  Files          11       11           
  Lines        1066     1066           
=======================================
  Hits          475      475           
  Misses        542      542           
  Partials       49       49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8701522...0133b33. Read the comment docs.

@philipatl philipatl requested a review from primalmotion Mar 25, 2020
@philipatl

This comment has been minimized.

Copy link
Contributor Author

philipatl commented Mar 25, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "windows-cert-bug-reorg",
    "component": "enforcerd",
    "pr-id": "1635",
    "commit-sha": "84d9aa4998b87c6852bbf4ac24a75e6fea54c81e",
    "pipeline": "master"
  },
  {
    "project": "windows-cert-bug-reorg",
    "component": "trireme-lib",
    "pr-id": "1013",
    "commit-sha": "e8b39e5ef45d8f3ffd2dca5c8038df9fbb400fd6",
    "pipeline": "master"
  },
  {
    "project": "windows-cert-bug-reorg",
    "component": "tg",
    "pr-id": "20",
    "commit-sha": "0133b339203ff9a0361fcebeecd5f3ce0bc9fa2a",
    "pipeline": "master"
  },
  {
    "project": "windows-cert-bug-reorg",
    "component": "apoctl",
    "pr-id": "233",
    "commit-sha": "9c4a44cb51c958c903531778103616c3c0d90966",
    "pipeline": "master"
  }
]
1 similar comment
@philipatl

This comment has been minimized.

Copy link
Contributor Author

philipatl commented Mar 25, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "windows-cert-bug-reorg",
    "component": "enforcerd",
    "pr-id": "1635",
    "commit-sha": "84d9aa4998b87c6852bbf4ac24a75e6fea54c81e",
    "pipeline": "master"
  },
  {
    "project": "windows-cert-bug-reorg",
    "component": "trireme-lib",
    "pr-id": "1013",
    "commit-sha": "e8b39e5ef45d8f3ffd2dca5c8038df9fbb400fd6",
    "pipeline": "master"
  },
  {
    "project": "windows-cert-bug-reorg",
    "component": "tg",
    "pr-id": "20",
    "commit-sha": "0133b339203ff9a0361fcebeecd5f3ce0bc9fa2a",
    "pipeline": "master"
  },
  {
    "project": "windows-cert-bug-reorg",
    "component": "apoctl",
    "pr-id": "233",
    "commit-sha": "9c4a44cb51c958c903531778103616c3c0d90966",
    "pipeline": "master"
  }
]
@primalmotion primalmotion merged commit d13ca9b into master Mar 25, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 8701522...0133b33
Details
codecov/project 44.55% (+0.00%) compared to 8701522
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@primalmotion primalmotion deleted the wincertbug branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.