New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: do not mask errors #414

Merged
merged 7 commits into from Dec 1, 2017

Conversation

Projects
None yet
2 participants
@primalmotion
Member

primalmotion commented Dec 1, 2017

will certainly not pass the tests.

@bvandewalle

This comment has been minimized.

Show comment
Hide comment
@bvandewalle

bvandewalle Dec 1, 2017

Member

Good refactoring, well needed.

A lot of those errors were modified to (or were already) start with a capital letter.
AFAIK, best practice is to start errors with a lower case

Member

bvandewalle commented Dec 1, 2017

Good refactoring, well needed.

A lot of those errors were modified to (or were already) start with a capital letter.
AFAIK, best practice is to start errors with a lower case

@primalmotion

This comment has been minimized.

Show comment
Hide comment
@primalmotion

primalmotion Dec 1, 2017

Member

yeah, well I'll let that privilege to somebody else :)

Member

primalmotion commented Dec 1, 2017

yeah, well I'll let that privilege to somebody else :)

@primalmotion

This comment has been minimized.

Show comment
Hide comment
@primalmotion

primalmotion Dec 1, 2017

Member

Rah I did it :)

Member

primalmotion commented Dec 1, 2017

Rah I did it :)

@bvandewalle

This comment has been minimized.

Show comment
Hide comment
@bvandewalle

bvandewalle Dec 1, 2017

Member

I knew you wouldn't resist :)

Member

bvandewalle commented Dec 1, 2017

I knew you wouldn't resist :)

@primalmotion primalmotion merged commit 870bdfd into master Dec 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@primalmotion primalmotion deleted the error-masking branch Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment