New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Major] Split trireme #464

Merged

dstiliadis merged 31 commits into master from split-trireme

Feb 13, 2018

Contributor

dstiliadis commented Feb 6, 2018

Description

This PR splits trireme into two modules and separates the controllers from the monitor. It also replaces the RCP interface for monitor events with a REST API.

dstiliadis added 3 commits

February 6, 2018 07:46


          Split trireme implementation

72dc226


          Increase linter deadline


          Skip docker mock from linter

671937c

codecov bot commented Feb 6, 2018 •

edited

Codecov Report

Merging #464 into master will decrease coverage by 0.84%.
The diff coverage is 42.06%.

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   55.02%   54.18%   -0.85%     
==========================================
  Files          48       52       +4     
  Lines        5621     5498     -123     
==========================================
- Hits         3093     2979     -114     
- Misses       2233     2236       +3     
+ Partials      295      283      -12

Impacted Files	Coverage Δ
controller/pkg/secrets/null.go	`0% <ø> (ø)`
...orcer/internal/statscollector/collector_trireme.go	`84.61% <ø> (ø)`
controller/internal/enforcer/acls/aclcache.go	`94.11% <ø> (ø)`
...troller/internal/supervisor/iptablesctrl/ipsets.go	`50.7% <ø> (ø)`
controller/internal/enforcer/acls/acl.go	`78.94% <ø> (ø)`
controller/pkg/fqconfig/fqconfig.go	`82.19% <ø> (ø)`
controller/internal/supervisor/supervisormock.go	`0% <ø> (ø)`
controller/pkg/packet/packet.go	`25.5% <ø> (ø)`
controller/pkg/secrets/compactpki.go	`85.45% <ø> (ø)`
controller/pkg/packet/types.go	`0% <ø> (ø)`
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73f3635...bf8890c. Read the comment docs.

dstiliadis added 19 commits

February 6, 2018 09:14


          Add validation tests

a94046b


          Adding some additional server tests


          Fix linter issues

3ad2610


          Tests and coverage should ignore mock directories

9060aba


          Adding some more unit tests

8d37c77


          Fix spelling errors to make the linter happy

d5e2bd5


          Add - to the allowed characters

b2401b6


          We need to setup runtime services with a method

6790b23


          Fixing uidmonitor

f7eb118


          Address linter problems

dfb4f0e


          Fixing updates and locks

e886359


          Remove the mode config variables

5c2499d


          Remove more references

bfda240


          Upgrading to go 1.9

085f423


          Disable user checks for testing

4eca670


          disable user validation tests

50436dd


          Fix resync

94aa4cd


          Fix host mode containers

7ba09b1


          Kill in case of policy failure

9b2aa56

aporeto-inc deleted a comment

aporeto-inc deleted a comment

aporeto-inc deleted a comment

dstiliadis added 4 commits

February 10, 2018 22:54


          Fix tests


          Add metadata extraction in start

d3d2cbb


          Fix crash

a83b8b3


          Add uid pam plugin here

bcfb46b


          Fix uid resync

ac0ba1b

dstiliadis changed the title ~~Split trireme~~ [Major] Split trireme

dstiliadis and others added 4 commits

February 12, 2018 13:19


          Delete LICENSE

b4e4cf1


          Create LICENSE

a90ad24


          Update readme

4db5c7c


          Fix linter errors from Cgo

bf8890c

ghost commented Feb 12, 2018

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "component": "gaia",
    "pr-id": "97",
    "commit-sha": "7ed39741c931f28558d7fbccd0e101ce043dc886"
  },
  {
    "component": "enforcerd",
    "pr-id": "449",
    "commit-sha": "434bd874f27171a24ed8f73d4434a023e4fc4680"
  },
  {
    "component": "apotests",
    "pr-id": "1110",
    "commit-sha": "ba0e0b2b45dc92579eff37612b6c9913c56c799a"
  },
  {
    "component": "apoctl",
    "pr-id": "112",
    "commit-sha": "933e6408d405c45ad84b4b27e1f51e6b9de20711"
  },
  {
    "component": "trireme-lib",
    "pr-id": "464",
    "commit-sha": "bf8890cd18bda5ac41199254f5e0d8bc71375251"
  },
  {
    "component": "squall",
    "pr-id": "307",
    "commit-sha": "70500ded23360342fa01d007fdafb852957b27a8"
  }
]

ghost commented Feb 13, 2018

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "component": "trireme-lib",
    "pr-id": "464",
    "commit-sha": "bf8890cd18bda5ac41199254f5e0d8bc71375251"
  },
  {
    "component": "squall",
    "pr-id": "307",
    "commit-sha": "70500ded23360342fa01d007fdafb852957b27a8"
  },
  {
    "component": "gaia",
    "pr-id": "97",
    "commit-sha": "7ed39741c931f28558d7fbccd0e101ce043dc886"
  },
  {
    "component": "enforcerd",
    "pr-id": "449",
    "commit-sha": "434bd874f27171a24ed8f73d4434a023e4fc4680"
  },
  {
    "component": "apotests",
    "pr-id": "1110",
    "commit-sha": "6c8f29d7fb613163edd89859bb53340974de2260"
  },
  {
    "component": "apoctl",
    "pr-id": "112",
    "commit-sha": "933e6408d405c45ad84b4b27e1f51e6b9de20711"
  }
]

ghost commented Feb 13, 2018

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "component": "apoctl",
    "pr-id": "112",
    "commit-sha": "933e6408d405c45ad84b4b27e1f51e6b9de20711"
  },
  {
    "component": "trireme-lib",
    "pr-id": "464",
    "commit-sha": "bf8890cd18bda5ac41199254f5e0d8bc71375251"
  },
  {
    "component": "squall",
    "pr-id": "307",
    "commit-sha": "70500ded23360342fa01d007fdafb852957b27a8"
  },
  {
    "component": "gaia",
    "pr-id": "97",
    "commit-sha": "7ed39741c931f28558d7fbccd0e101ce043dc886"
  },
  {
    "component": "enforcerd",
    "pr-id": "449",
    "commit-sha": "434bd874f27171a24ed8f73d4434a023e4fc4680"
  },
  {
    "component": "apotests",
    "pr-id": "1110",
    "commit-sha": "6c8f29d7fb613163edd89859bb53340974de2260"
  }
]

ghost commented Feb 13, 2018

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "component": "trireme-lib",
    "pr-id": "464",
    "commit-sha": "bf8890cd18bda5ac41199254f5e0d8bc71375251"
  },
  {
    "component": "enforcerd",
    "pr-id": "449",
    "commit-sha": "434bd874f27171a24ed8f73d4434a023e4fc4680"
  },
  {
    "component": "apotests",
    "pr-id": "1110",
    "commit-sha": "3409d430d55239bbae5a9f6bae011abc54225f61"
  },
  {
    "component": "apoctl",
    "pr-id": "112",
    "commit-sha": "933e6408d405c45ad84b4b27e1f51e6b9de20711"
  },
  {
    "component": "gaia",
    "pr-id": "97",
    "commit-sha": "7ed39741c931f28558d7fbccd0e101ce043dc886"
  },
  {
    "component": "squall",
    "pr-id": "307",
    "commit-sha": "70500ded23360342fa01d007fdafb852957b27a8"
  }
]

ghost commented Feb 13, 2018

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "component": "squall",
    "pr-id": "307",
    "commit-sha": "70500ded23360342fa01d007fdafb852957b27a8"
  },
  {
    "component": "trireme-lib",
    "pr-id": "464",
    "commit-sha": "bf8890cd18bda5ac41199254f5e0d8bc71375251"
  },
  {
    "component": "enforcerd",
    "pr-id": "449",
    "commit-sha": "434bd874f27171a24ed8f73d4434a023e4fc4680"
  },
  {
    "component": "apotests",
    "pr-id": "1110",
    "commit-sha": "3409d430d55239bbae5a9f6bae011abc54225f61"
  },
  {
    "component": "apoctl",
    "pr-id": "112",
    "commit-sha": "1e8a8eea5f2f1b9c5b5b3c1eec99f0d49363727f"
  }
]

ghost commented Feb 13, 2018

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "component": "trireme-lib",
    "pr-id": "464",
    "commit-sha": "bf8890cd18bda5ac41199254f5e0d8bc71375251"
  },
  {
    "component": "enforcerd",
    "pr-id": "449",
    "commit-sha": "434bd874f27171a24ed8f73d4434a023e4fc4680"
  },
  {
    "component": "apotests",
    "pr-id": "1110",
    "commit-sha": "d8364e8715a393a4f124dcd758fcddfd030a02e3"
  },
  {
    "component": "apoctl",
    "pr-id": "112",
    "commit-sha": "1e8a8eea5f2f1b9c5b5b3c1eec99f0d49363727f"
  },
  {
    "component": "squall",
    "pr-id": "307",
    "commit-sha": "70500ded23360342fa01d007fdafb852957b27a8"
  }
]

ghost commented Feb 13, 2018

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "component": "apotests",
    "pr-id": "1110",
    "commit-sha": "389dc130e912ea7ed7216f4ba0af8ea3902d6da8"
  },
  {
    "component": "apoctl",
    "pr-id": "112",
    "commit-sha": "1e8a8eea5f2f1b9c5b5b3c1eec99f0d49363727f"
  },
  {
    "component": "squall",
    "pr-id": "307",
    "commit-sha": "70500ded23360342fa01d007fdafb852957b27a8"
  },
  {
    "component": "trireme-lib",
    "pr-id": "464",
    "commit-sha": "bf8890cd18bda5ac41199254f5e0d8bc71375251"
  },
  {
    "component": "enforcerd",
    "pr-id": "449",
    "commit-sha": "434bd874f27171a24ed8f73d4434a023e4fc4680"
  }
]

ghost commented Feb 13, 2018

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "component": "trireme-lib",
    "pr-id": "464",
    "commit-sha": "bf8890cd18bda5ac41199254f5e0d8bc71375251"
  },
  {
    "component": "enforcerd",
    "pr-id": "449",
    "commit-sha": "434bd874f27171a24ed8f73d4434a023e4fc4680"
  },
  {
    "component": "apotests",
    "pr-id": "1110",
    "commit-sha": "6bbbd9401f3c1ef77d1bf3c17227cd01a3568794"
  },
  {
    "component": "apoctl",
    "pr-id": "112",
    "commit-sha": "1e8a8eea5f2f1b9c5b5b3c1eec99f0d49363727f"
  },
  {
    "component": "squall",
    "pr-id": "307",
    "commit-sha": "70500ded23360342fa01d007fdafb852957b27a8"
  }
]

dstiliadis merged commit c59c5f8 into master

dstiliadis deleted the split-trireme branch

February 13, 2018 15:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment