Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help text and image size #25

Merged
merged 4 commits into from Jul 14, 2020
Merged

Help text and image size #25

merged 4 commits into from Jul 14, 2020

Conversation

breyell
Copy link
Contributor

@breyell breyell commented Jul 10, 2020

Adds help text to make image selection and processing more transparent. Also adds support for another iOS image size.

@breyell breyell self-assigned this Jul 10, 2020
@breyell breyell requested review from boutell, abea and stuartromanek and removed request for boutell July 10, 2020 20:25
Copy link
Member

@stuartromanek stuartromanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're here, why not just trim the min size down to something closer to the new use cases? Like 200x200 ?
I think the 500x500 size is a legacy thing

Copy link
Contributor

@abea abea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Let's reduce the min size.

@breyell
Copy link
Contributor Author

breyell commented Jul 13, 2020

Agreed! Reduced to 200x200.

Update help text
@breyell breyell merged commit 6cd2e79 into master Jul 14, 2020
@abea
Copy link
Contributor

abea commented Jul 14, 2020

Remember those Changelog updates, folks.

@abea abea deleted the help-text-and-image-size branch July 14, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants