Revert https://github.com/punkave/sanitize-html/pull/226 #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'browser' field should be a node module intended for use in a web browser, eg. using the `window` object or similar as per https://docs.npmjs.com/files/package.json#browser . It's what webpack imports if the key exists. This points it to browserified source code which isn't what webpack wants. Also the sanitize-html.js published to npm seems to be an empty module, I don't know why this is yet, but either way I don't believe this key should be here.
Closed
felixfbecker
approved these changes
Aug 2, 2018
felixfbecker
left a comment
felixfbecker
left a comment
There was a problem hiding this comment.
browser doesn't mean it has to be bundled, it just means it shouldn't use (non-polyfillable) browser-incompatible code. It should still be unbundled so dependencies can be deduped if another package depends on the same dependencies, so they only end up in the final bundle once.
Member
|
Hmm. This fix gives me back good files in dist/, even if I don't restore the old package-lock.json first. I published 1.18.4. Please take a look. I'm out today but doing my best to check in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'browser' field should be a node module intended for use in
a web browser, eg. using the
windowobject or similar as perhttps://docs.npmjs.com/files/package.json#browser . It's what
webpack imports if the key exists. This points it to browserified
source code which isn't what webpack wants.
Also the sanitize-html.js published to npm seems to be an empty
module, I don't know why this is yet, but either way I don't
believe this key should be here. It description says it was to make
packers use the transpiled version rather than the ES6 version,
but it was already pointing at
dist/index.jswhich is the babeltranspiled version.
Fixes #241