new and interesting iframe validation exploits #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abea
suggested changes
Jan 26, 2021
CHANGELOG.md
Outdated
| ## 2.3.1 (2021-01-22): | ||
| - Uses the standard WHATWG URL parser to stop IDNA (Internationalized Domain Name) attacks on the iframe hostname validator. Thanks to Ron Masas of Checkmarx for pointing out the issue and suggesting the use of the WHATWG parser. | ||
| - Uses the standard WHATWG URL parser to stop IDNA (Internationalized Domain Name) attacks on the iframe hostname validator. Thanks to Ron Masas of <a href="https://www.checkmarx.com/">Checkmarx</a> for pointing out the issue and suggesting the use of the WHATWG parser. |
There was a problem hiding this comment.
We can use markdown syntax: [Checkmarx](https://www.checkmarx.com)
CHANGELOG.md
Outdated
| @@ -1,7 +1,10 @@ | |||
| # Changelog | |||
|
|
|||
| ## 2.3.2 (2021-01-26): | |||
| - Additional fixes for iframe validation exploits. Prevent exploits based on browsers' tolerance of the use of "\" rather than "/" and the presence of whitespace at this point in the URL. Thanks to Ron Masas of <a href="https://www.checkmarx.com/">Checkmarx</a> for pointing out the issue and writing unit tests. | |||
There was a problem hiding this comment.
Markdown syntax for the link here.
|
The code looks good. |
abea
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WHATWG URL parser doesn't agree with browsers about these, so a regexp of our own is needed. Fortunately however they rely on behaviors regarding the protocol part of the URL which is the easiest part to clean before passing to WHATWG. Tests contributed by our friends at Checkmarx.