Builders #21

Open
wants to merge 4 commits into
from

3 participants

@chikamichi

Saw that on IRC. Builders support for Apotomo, with a larger pending refactoring I guess.

chikamichi added some commits Mar 20, 2011
@chikamichi chikamichi support for Cells builders feature
This comes redundant with Cells internals, but this is due to what may
be a flaw in current Apotomo's design, which bypass Cells workflow
(#render_cell_for) and hook directly into AbstractController::Rendering.

Using Cells' #create_cell_for proved cumbersome due to the different
naming conventions, so here's the most direct patch I found atm.
dba14fe
@chikamichi chikamichi support for Cells builders feature
This comes redundant with Cells internals, but this is due to what may
be a flaw in current Apotomo's design, which bypass Cells workflow
(#render_cell_for) and hook directly into AbstractController::Rendering.

Using Cells' #create_cell_for proved cumbersome due to the different
naming conventions, so here's the most direct patch I found atm.
7340f28
@chikamichi chikamichi Merge branch 'builders' of github.com:chikamichi/apotomo into builders 8631a8d
@chikamichi chikamichi Merge remote-tracking branch 'upstream/master' into builders d87896b
@kuraga

@apotonick @chikamichi Don't you what there were on IRC? :-D It's seems to be down now... And what does this code do? Thanks for attention.

@chikamichi

Honestly I didn't understand your question :)

@kuraga

@chikamichi You wrote: 'Saw that on IRC'. But I can't open IRC channel.
What does this code do?

@apotonick
Owner

This code adds cells' builder functionality (https://github.com/apotonick/cells/blob/master/README.rdoc#builders) to apotomo. I had a conceptual issue with that and forgot to work on it.

@chikamichi

Honestly I don't remember much about this too. It's been 2 years.

@kuraga

So 👍 to merge :) Are tests and docs necessary?

@apotonick
Owner
@kuraga

@apotonick haven't you remember now? :-)

@chikamichi

Hi @apotonick ! I think we should close this PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment