Unit tests of namespaced cells are put in proper directory hierarchy #113

Merged
merged 1 commit into from Oct 5, 2012

4 participants

@pgaertig

This is simple fix which puts test file of namespaced cell in proper /test/cells/ sub-directory reflecting the cell's code hierarchy. Rails' controller generator is using the same way. Test case updated.

@pboling

Wait... you can namespace cells and nest them in subdirs? Can you set the view path too? I guess I've been using them so long I assumed I had tried and it didn't work!

@pboling

@apotonick: If this is legit, then +1. NAMESPACE ALL THE THINGS!!!

@lulalala

+1 for this change. Currently my generated spec files are not in the namespaced location.

@apotonick apotonick merged commit a3f1f18 into apotonick:master Oct 5, 2012
@apotonick
Owner

We also need that change in rspec-cells, @gertas are you ready?

@pgaertig pgaertig referenced this pull request in apotonick/rspec-cells Oct 5, 2012
Merged

Generate proper spec for namespaced cell #19

@pgaertig

It is done now apotonick/rspec-cells#19 . I did a basic test with real app - just running rspec, but please @lulalala test it with yours as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment