Ensure metrics are deleted for resources in a deleted namespace

[TGPSKI]

This MR fixes bug DVO-31: Deleted Namespace and Kind still show in DVO grafana / prometheus.

Reconcile watches objects and triggers validations.RunValidations(), where DVO output is shipped to DVO's /metrics endpoint. Delete metric labels operations are also handled in RunValidations().

On deletion, gvk.Kind is an empty string for all resource types besides "Pod". This string is passed into RunValidations and is used to construct the prometheus labels for the associated metric.

When a deletion event is passed to RunValidations for non-pod resources (Deployment, ReplicaSet), promLabels is missing the kind field, and as such can't associate the provided deletion event with the existing metrics. For an example nginx deployment, the prom labels do not exist / will return multiple labels.

promLabels := getPromLabels(
	request.Namespace,
	request.Name,
	kind,
)

promLabels := getPromLabels(
	'check',
	'nginx'
	'',
)

Passing gr.reconciledKind into RunValidations instead of gvk.Kind fixes this problem. Deployment and ReplicaSet kinds are passed to the validation method, and the promLabels are found and deleted.

[codecov-commenter]

Codecov Report

Merging #124 (ad51dc5) into master (83bacc7) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   36.70%   36.54%   -0.17%     
==========================================
  Files          15       15              
  Lines         395      394       -1     
==========================================
- Hits          145      144       -1     
  Misses        230      230              
  Partials       20       20              

Impacted Files	Coverage Δ
pkg/controller/generic_reconciler.go	29.41% <100.00%> (-2.02%)	⬇️

[rrati]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rrati, TGPSKI

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rrati]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment