-
Notifications
You must be signed in to change notification settings - Fork 49
DVO-114: Add watcher prototype to handle configuration changes #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DVO-114: Add watcher prototype to handle configuration changes #251
Conversation
|
@ncaak: This pull request references DVO-114 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test lint |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 44.39% 43.40% -1.00%
==========================================
Files 22 23 +1
Lines 910 940 +30
==========================================
+ Hits 404 408 +4
- Misses 472 497 +25
- Partials 34 35 +1
|
|
I think I like the approach in 34af45a a little bit more, because it allows to define the informer only for the particular namespace. |
Ok, I'll rework it using factory pattern. Maybe that way also we can add more unit tests. |
|
/hold |
|
OK so let's merge this and we can continue to build upon it. Thanks. |
summary