Skip to content

Conversation

@ncaak
Copy link
Contributor

@ncaak ncaak commented Aug 9, 2023

summary

  • Allow the project to change the configuration in execution time, updating the validations with the new configuration updated on the ConfigMap

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 9, 2023

@ncaak: This pull request references DVO-111 which is a valid jira issue.

In response to this:

summary

  • Allow the project to change the configuration in execution time, updating the validations with the new configuration updated on the ConfigMap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 9, 2023
@ncaak ncaak marked this pull request as ready for review August 22, 2023 15:03
@openshift-ci openshift-ci bot requested review from maorfr and npecka August 22, 2023 15:03
@ncaak
Copy link
Contributor Author

ncaak commented Aug 22, 2023

/test all

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Merging #263 (fde9314) into master (b64e5ef) will decrease coverage by 4.95%.
Report is 5 commits behind head on master.
The diff coverage is 14.07%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   45.01%   40.07%   -4.95%     
==========================================
  Files          25       25              
  Lines        1004     1118     +114     
==========================================
- Hits          452      448       -4     
- Misses        517      635     +118     
  Partials       35       35              
Files Changed Coverage Δ
main.go 0.00% <0.00%> (ø)
pkg/prometheus/prometheus.go 15.00% <0.00%> (-11.67%) ⬇️
pkg/configmap/configmap_watcher.go 13.04% <7.50%> (ø)
pkg/controller/generic_reconciler.go 61.97% <10.52%> (-5.84%) ⬇️
pkg/validations/utils.go 46.15% <40.00%> (-53.85%) ⬇️
pkg/validations/validation_engine.go 41.93% <42.85%> (-5.29%) ⬇️

@ncaak ncaak force-pushed the DVO-111/dynamic-validation-engine branch from a178b5c to 043a69f Compare September 12, 2023 14:13
@openshift-ci openshift-ci bot removed the lgtm label Sep 12, 2023
@tremes
Copy link
Contributor

tremes commented Sep 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit a9c60cf into app-sre:master Sep 13, 2023
@ncaak ncaak deleted the DVO-111/dynamic-validation-engine branch February 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants