Skip to content

Conversation

@tremes
Copy link
Contributor

@tremes tremes commented Sep 15, 2023

No description provided.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 15, 2023

@tremes: This pull request references DVO-141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Merging #274 (928e301) into master (bfb72f6) will increase coverage by 3.22%.
Report is 1 commits behind head on master.
The diff coverage is 78.02%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   40.79%   44.02%   +3.22%     
==========================================
  Files          25       25              
  Lines        1157     1129      -28     
==========================================
+ Hits          472      497      +25     
+ Misses        650      600      -50     
+ Partials       35       32       -3     
Files Changed Coverage Δ
main.go 0.00% <0.00%> (ø)
pkg/validations/base.go 100.00% <ø> (+20.22%) ⬆️
pkg/validations/utils.go 70.21% <ø> (+38.06%) ⬆️
pkg/controller/generic_reconciler.go 62.37% <33.33%> (+0.19%) ⬆️
pkg/validations/validation_engine.go 83.12% <85.00%> (+23.50%) ⬆️

... and 2 files with indirect coverage changes

@tremes tremes changed the title WIP DVO-141: remove global validationengine variable DVO-141: remove global validationengine variable Sep 15, 2023
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7d40738 into app-sre:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants