Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"quit" should also exit #19

Closed
rjrodger opened this issue Feb 2, 2016 · 8 comments · Fixed by #28
Closed

"quit" should also exit #19

rjrodger opened this issue Feb 2, 2016 · 8 comments · Fixed by #28

Comments

@rjrodger
Copy link

rjrodger commented Feb 2, 2016

No description provided.

@AdrianRossouw
Copy link
Contributor

hey @rjrodger, i'm not sure I have the context right to understand what this means...

do you mean that if you quit the fuge shell, it doesn't exit the services?

@rjrodger
Copy link
Author

rjrodger commented Feb 3, 2016

you can type exit to quit, but you can't type quit to exit

@matt-oc
Copy link
Contributor

matt-oc commented Feb 4, 2016

@rjrodger I had this implemented in my current pull request but was told that two way is not necessary. Happy to make the change again though.

@mcollina
Copy link

mcollina commented Feb 4, 2016

That was me. I think having two ways for exiting is confusing.

exit is the standard for exiting terminals, you can type that in bash and it will exit the prompt. You can't type quit.

@AdrianRossouw
Copy link
Contributor

i think having an alias for certain commands is fine. we would only document exit.

@pelger
Copy link
Contributor

pelger commented Feb 4, 2016

quit and exit already :)

@AdrianRossouw
Copy link
Contributor

i'm on this.

ctrl-d should also exit.

@rjrodger
Copy link
Author

rjrodger commented Feb 5, 2016

+1 user experience win

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants