feat: docs addition for RS SearchBox #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
siddharthlatest
requested changes
Nov 22, 2021
|
|
||
| ```js | ||
| <SearchBox | ||
| componentId="SearchBoxSensor" |
There was a problem hiding this comment.
@mohdashraf010897 Check the indent here.
| <br /> | ||
|
|
||
| <!-- Example will be added once the implementation PR is merged --> | ||
| <iframe src="https://codesandbox.io/embed/github/appbaseio/reactivesearch/tree/next/packages/web/examples/DataSearch" style="width:100%; height:500px; border:0; border-radius: 4px; overflow:hidden;" sandbox="allow-modals allow-forms allow-popups allow-scripts allow-same-origin"></iframe> |
There was a problem hiding this comment.
@mohdashraf010897 We should update this example before merging this PR.
1 task
bietkul
suggested changes
Jan 3, 2022
bietkul
suggested changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type For ReactiveSearch, we created a Searchbox component. This PR adds docs support for the same.
Implementation PR: appbaseio/reactivesearch#1806
Notion Link