New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Filter dropdown UI doesn't go away after selecting a value #174

Closed
siddharthlatest opened this Issue Mar 22, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@siddharthlatest
Member

siddharthlatest commented Mar 22, 2018

Tell us where you are using Dejavu (Hosted web app, Chrome extension, Docker Image, Within appbase.io)

Hosted web app

What is the version of Dejavu that you are using?

1.5.0

Describe the issue that you are seeing, or the feature request :-), include any screenshots as necessary.

The below GIF depicts the issue. When I select the less than filter here and apply it, it continues showing the dropdown UI even after the filter is applied.

@siddharthlatest siddharthlatest added the bug label Mar 22, 2018

@MPierre9

This comment has been minimized.

Contributor

MPierre9 commented Mar 27, 2018

Hello! Do you mind if I try to fix this? Also any tips on where the bug may be located in the source code. Thanks!

@divyanshu013

This comment has been minimized.

Member

divyanshu013 commented Mar 27, 2018

Hi @MPierre9! Please feel free to take this up.

I suspect this is an issue with react-bootstrap which we're using currently in dejavu. I fixed a similar issue with popovers where I'd to simulate a click outside by using document.body.click(). I think a similar fix should work here after the filters are applied. Check the FilterDropdown component at live/src/js/table/FilterDropdown.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment