New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web & vue): icons added for recent & popular searches #1635
Conversation
@anik-ghosh-au7 Can we use idiomatic naming convention for the innerClass keys? We can use the same name for them as the class names. Can you also include a link to the doc changes PR associated with this enhancement? We should include a storybook story for the same. |
@siddharthlatest I will make the changes and create the PR for docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anik-ghosh-au7 Make the following changes:
- The default color of the icon doesn't match the suggestion text. The color of the icons is dark and bold which catches the user’s eye from the suggestion.
Share a demo after making the changes.
Final demo (react & vue) - |
@bietkul, I have made the above changes Final demo - |
Before submitting a pull request, please make sure the following is done:
The below-mentioned changes are applicable for the DataSearch and Category components
recentSearchesIcon
orpopularSearchesIcon
propsrecent-search-icon
orpopular-search-icon
keys of the innerClass propPlease make sure that there are no linting errors in the code.
Add a demo video/gif/screenshot to explain how did you test the fix.
If it is a global change, try to add any side effects that it could have.
Create a PR to add/update the docs (if needed) at here.
feat: recent searches and popular suggestions icons added Docs#180
Create a PR to add/update the storybook (if needed) at here.