Skip to content

Fix/searchbox autosuggest bug #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Fix/searchbox autosuggest bug #1838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7853fea
fix(web): fix logical condition to open dropdown only when autoggest …
mohdashraf010897 Jan 10, 2022
b37e2f8
fix(web): updated snaspshots for SearchBox
mohdashraf010897 Jan 10, 2022
4bf326a
Merge branch 'next' into fix/searchbox-autosuggest-bug
mohdashraf010897 Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/web/src/components/search/SearchBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,9 +829,7 @@ const SearchBox = (props) => {
listenForFocusShortcuts();
}, []);

const hasSuggestions = () =>
(Array.isArray(props.defaultSuggestions) && props.defaultSuggestions.length)
|| (Array.isArray(parsedSuggestions()) && parsedSuggestions().length);
const hasSuggestions = () => (Array.isArray(parsedSuggestions()) && parsedSuggestions().length);

return (
<Container style={props.style} className={props.className}>
Expand All @@ -840,7 +838,7 @@ const SearchBox = (props) => {
{props.title}
</Title>
)}
{hasSuggestions() || props.autosuggest ? (
{hasSuggestions() && props.autosuggest ? (
<Downshift
id={`${props.componentId}-downshift`}
onChange={onSuggestionSelected}
Expand Down
112 changes: 28 additions & 84 deletions packages/web/src/components/search/__snapshots__/SearchBox.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,24 +164,16 @@ exports[`should display/ hide (search/ clear )icon when (showIcon/ showClear )pr
className="emotion-7 emotion-8"
>
<input
aria-activedescendant={null}
aria-autocomplete="list"
aria-expanded={false}
aria-label="MockSearchBox"
autoComplete="off"
autoFocus={undefined}
className=" emotion-9 emotion-10"
id="MockSearchBox-downshift-input"
onBlur={[Function]}
className="emotion-9 emotion-10"
onBlur={undefined}
onChange={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onFocus={undefined}
onKeyDown={undefined}
onKeyPress={undefined}
onKeyUp={undefined}
placeholder="Search"
role="combobox"
type={undefined}
value="test"
/>
<div>
Expand Down Expand Up @@ -1206,24 +1198,16 @@ exports[`should render (prefixed/ suffixed) UI nodes with searchbox when (addonB
className="emotion-9 emotion-10"
>
<input
aria-activedescendant={null}
aria-autocomplete="list"
aria-expanded={false}
aria-label="MockSearchBox"
autoComplete="off"
autoFocus={undefined}
className=" emotion-11 emotion-12"
id="MockSearchBox-downshift-input"
onBlur={[Function]}
className="emotion-11 emotion-12"
onBlur={undefined}
onChange={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onFocus={undefined}
onKeyDown={undefined}
onKeyPress={undefined}
onKeyUp={undefined}
placeholder="Search"
role="combobox"
type={undefined}
value=""
/>
<div>
Expand Down Expand Up @@ -1440,24 +1424,16 @@ exports[`should render SearchBox 1`] = `
className="emotion-7 emotion-8"
>
<input
aria-activedescendant={null}
aria-autocomplete="list"
aria-expanded={false}
aria-label="MockSearchBox"
autoComplete="off"
autoFocus={undefined}
className=" emotion-9 emotion-10"
id="MockSearchBox-downshift-input"
onBlur={[Function]}
className="emotion-9 emotion-10"
onBlur={undefined}
onChange={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onFocus={undefined}
onKeyDown={undefined}
onKeyPress={undefined}
onKeyUp={undefined}
placeholder="Search"
role="combobox"
type={undefined}
value=""
/>
<div>
Expand Down Expand Up @@ -1678,24 +1654,16 @@ exports[`should render SearchBox with title 1`] = `
className="emotion-9 emotion-10"
>
<input
aria-activedescendant={null}
aria-autocomplete="list"
aria-expanded={false}
aria-label="MockSearchBox"
autoComplete="off"
autoFocus={undefined}
className=" emotion-11 emotion-12"
id="MockSearchBox-downshift-input"
onBlur={[Function]}
className="emotion-11 emotion-12"
onBlur={undefined}
onChange={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onFocus={undefined}
onKeyDown={undefined}
onKeyPress={undefined}
onKeyUp={undefined}
placeholder="Search"
role="combobox"
type={undefined}
value=""
/>
<div>
Expand Down Expand Up @@ -3379,24 +3347,16 @@ exports[`should render search icon on the right 1`] = `
className="emotion-7 emotion-8"
>
<input
aria-activedescendant={null}
aria-autocomplete="list"
aria-expanded={true}
aria-label="MockSearchBox"
autoComplete="off"
autoFocus={undefined}
className=" emotion-9 emotion-10"
id="MockSearchBox-downshift-input"
onBlur={[Function]}
className="emotion-9 emotion-10"
onBlur={undefined}
onChange={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onFocus={undefined}
onKeyDown={undefined}
onKeyPress={undefined}
onKeyUp={undefined}
placeholder="Search"
role="combobox"
type={undefined}
value=""
/>
<div>
Expand Down Expand Up @@ -3605,24 +3565,16 @@ exports[`should render with a default value when defaultValue prop is set 1`] =
className="emotion-7 emotion-8"
>
<input
aria-activedescendant={null}
aria-autocomplete="list"
aria-expanded={false}
aria-label="MockSearchBox"
autoComplete="off"
autoFocus={undefined}
className=" emotion-9 emotion-10"
id="MockSearchBox-downshift-input"
onBlur={[Function]}
className="emotion-9 emotion-10"
onBlur={undefined}
onChange={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onFocus={undefined}
onKeyDown={undefined}
onKeyPress={undefined}
onKeyUp={undefined}
placeholder="Search"
role="combobox"
type={undefined}
value="test"
/>
<div>
Expand Down Expand Up @@ -3830,24 +3782,16 @@ exports[`should show voice search when showVoiceSearch prop is set 1`] = `
className="emotion-7 emotion-8"
>
<input
aria-activedescendant={null}
aria-autocomplete="list"
aria-expanded={false}
aria-label="MockSearchBox"
autoComplete="off"
autoFocus={undefined}
className=" emotion-9 emotion-10"
id="MockSearchBox-downshift-input"
onBlur={[Function]}
className="emotion-9 emotion-10"
onBlur={undefined}
onChange={[Function]}
onClick={[Function]}
onFocus={[Function]}
onKeyDown={[Function]}
onFocus={undefined}
onKeyDown={undefined}
onKeyPress={undefined}
onKeyUp={undefined}
placeholder="Search"
role="combobox"
type={undefined}
value=""
/>
<div>
Expand Down