Use appcd-winreg where possible, add Java 9 registry key #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
requested changes
Oct 13, 2017
|
|
||
| let cachedLocale; | ||
|
|
||
| /** | ||
| * Determines the current locale of this machine. | ||
| * | ||
| * @returns {String} | ||
| * @returns {Promise<String>} |
There was a problem hiding this comment.
I have never documented the resolved data type because I was unaware of a standardized way of doing so. Is this what people are doing these days?
There was a problem hiding this comment.
Then, let's start using the @async keyword and @returns {Promise<type>}. @async should appear after the description, but before the first @param.
| cachedLocale = m ? m[1].replace(/_/g, '-') : null; | ||
| } | ||
| } else { | ||
| let m = spawnSync('locale').stdout.toString().match(/^LANG="?([^".\s]+)/); | ||
| let { stdout } = await run('locale'); |
|
@cb1kenobi Changes made |
cb1kenobi
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use appcd-winreg in appcd-machine-id and appcd-response rather than manually spawning reg query
Add Java 9 registry key in jdk-plugin
Fix error in jdk-plugin when comparing jdk architectures