Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

TIMOB-4706: Android: Cannot debug an application while using require('some_js_module') #3

Open
wants to merge 2 commits into from

5 participants

@marshall

http://jira.appcelerator.org/browse/TIMOB-4706

This is the Rhino portion of this bug fix

@marshall marshall allow debugger string evaluation outside of the interrupted state (it…
… must be

called from the same thread though) TIMOB-4706
1e8d332
@billdawson

Code Review Accepted (functional'd via appcelerator/titanium_mobile#379)

@billdawson

Re-"functional"d and still accepted

@marshall

@billdawson so this is good to merge? ;)

@Thomasappcel

lets not be rash here gentlemen - are we sure we've had enough time to think about this pull?

@kwhinnery

This e-mail notification made my day :)

When are we doing the reunion BBQ?

@dizzymonkey

@marshall Rejected. Go to your corner :)

@marshall

@Thomasappcel I think the time might be near. can someone from your team functional? I don't trust @billdawson or @dizzymonkey ;)

@kwhinnery :meat_on_bone: :beers:

@billdawson

Heh, I just saw this. Most awesome. I guess my notification settings in Github prevented me seeing it earlier.

I'll click merge here... d'oh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 15, 2011
  1. @marshall

    allow debugger string evaluation outside of the interrupted state (it…

    marshall authored
    … must be
    
    called from the same thread though) TIMOB-4706
Commits on Aug 26, 2011
  1. @marshall
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 4 deletions.
  1. +1 −4 toolsrc/org/mozilla/javascript/tools/debugger/Dim.java
View
5 toolsrc/org/mozilla/javascript/tools/debugger/Dim.java
@@ -657,10 +657,7 @@ public Object eval(Scriptable scope, Scriptable thisObj, String expr) {
return result;
}
ContextData contextData = currentContextData();
- if (contextData == null || frameIndex >= contextData.frameCount()) {
- return result;
- }
- if (contextData.eventThreadFlag) {
+ if (contextData == null || contextData.eventThreadFlag) {
Context cx = Context.getCurrentContext();
result = do_eval(cx, scope, thisObj, expr);
} else {
Something went wrong with that request. Please try again.