Toolchain silently ignores invalid quotes in tiapp.xml #244

Closed
Bostwickenator opened this Issue May 2, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@Bostwickenator

Bostwickenator commented May 2, 2016

When adding modules the toolchain will happily process the following:
<module platform=“iphone” version="1.0.0">com.example.test</module>
silently and then cause run-time module lookup failures.

Change it to:
<module platform="iphone" version="1.0.0">com.example.test</module>
and everything works correctly

@cb1kenobi

This comment has been minimized.

Show comment
Hide comment
@cb1kenobi

cb1kenobi May 2, 2016

Member

Smart quotes are not valid in XML. I wonder what the XML parser library is doing. I wouldn't be surprised if the platform was being parsed as "“iphone”". I don't think we should naively replace all smart quotes with ascii quotes and properly scrubbing the smart quotes is more effort than it's worth. In other words, I don't think we're going to improve this.

Member

cb1kenobi commented May 2, 2016

Smart quotes are not valid in XML. I wonder what the XML parser library is doing. I wouldn't be surprised if the platform was being parsed as "“iphone”". I don't think we should naively replace all smart quotes with ascii quotes and properly scrubbing the smart quotes is more effort than it's worth. In other words, I don't think we're going to improve this.

@cb1kenobi cb1kenobi closed this May 2, 2016

@cb1kenobi cb1kenobi added the wontfix label May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment