Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain silently ignores invalid quotes in tiapp.xml #244

Closed
Bostwickenator opened this issue May 2, 2016 · 1 comment
Closed

Toolchain silently ignores invalid quotes in tiapp.xml #244

Bostwickenator opened this issue May 2, 2016 · 1 comment
Labels

Comments

@Bostwickenator
Copy link

@Bostwickenator Bostwickenator commented May 2, 2016

When adding modules the toolchain will happily process the following:
<module platform=“iphone” version="1.0.0">com.example.test</module>
silently and then cause run-time module lookup failures.

Change it to:
<module platform="iphone" version="1.0.0">com.example.test</module>
and everything works correctly

@cb1kenobi
Copy link
Member

@cb1kenobi cb1kenobi commented May 2, 2016

Smart quotes are not valid in XML. I wonder what the XML parser library is doing. I wouldn't be surprised if the platform was being parsed as "“iphone”". I don't think we should naively replace all smart quotes with ascii quotes and properly scrubbing the smart quotes is more effort than it's worth. In other words, I don't think we're going to improve this.

@cb1kenobi cb1kenobi closed this May 2, 2016
@cb1kenobi cb1kenobi added the wontfix label May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.