Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIDOC-104, TIDOC-76, TIDOC-210: Rewrote & updated Ti.Map module docs #1372

Merged
merged 11 commits into from Feb 10, 2012

Conversation

arthurevans
Copy link
Contributor

No description provided.

@arthurevans
Copy link
Contributor Author

Although it does not show in the diff, note that the original code sample (untouched in this revision) for Map.yml includes adding a custom property to the annotation object. Given the current discussions on best practices--should we be doing this in a code sample?

@WhichKatieDid
Copy link
Contributor

Documentation reviewed and accepted. WRT the original code sample, not sure if we should change it.

summary: Title of the annotation.
type: String

- name: map
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For android, we have the properties: title, subtitle, longitude, latitude, annotation, and clicksource. (Basically we have subtitle, longitude, and latitude instead of index and map)

@ayeung
Copy link
Contributor

ayeung commented Feb 9, 2012

Code reviewed, left some comments.

@arthurevans
Copy link
Contributor Author

@WhichKatieDid
Copy link
Contributor

Code reviewed, looks good for iOS. ----- Ayeung pointed out the thing about subtitle.

summary: Title of the annotation.
type: String

- name: subtitle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtitle is android only


- name: subtitle
summary: Subtitle of the annotation.
type: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an android feature? Click on iOS has "clicksource","annotation","map","title",and "index"

@ayeung
Copy link
Contributor

ayeung commented Feb 10, 2012

Code reviewed. Request Accepted

@WhichKatieDid
Copy link
Contributor

Code looks good. ACCEPTED

WhichKatieDid added a commit that referenced this pull request Feb 10, 2012
TIDOC-104, TIDOC-76, TIDOC-210: Rewrote & updated Ti.Map module docs
@WhichKatieDid WhichKatieDid merged commit 7b8359c into tidev:master Feb 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants