New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIDOC-104, TIDOC-76, TIDOC-210: Rewrote & updated Ti.Map module docs #1372
Conversation
Although it does not show in the diff, note that the original code sample (untouched in this revision) for Map.yml includes adding a custom property to the annotation object. Given the current discussions on best practices--should we be doing this in a code sample? |
Documentation reviewed and accepted. WRT the original code sample, not sure if we should change it. |
summary: Title of the annotation. | ||
type: String | ||
|
||
- name: map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For android, we have the properties: title, subtitle, longitude, latitude, annotation, and clicksource. (Basically we have subtitle, longitude, and latitude instead of index and map)
Code reviewed, left some comments. |
Related parity tickets: |
Code reviewed, looks good for iOS. ----- Ayeung pointed out the thing about subtitle. |
summary: Title of the annotation. | ||
type: String | ||
|
||
- name: subtitle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subtitle is android only
…le property in click event.
|
||
- name: subtitle | ||
summary: Subtitle of the annotation. | ||
type: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an android feature? Click on iOS has "clicksource","annotation","map","title",and "index"
Code reviewed. Request Accepted |
Code looks good. ACCEPTED |
TIDOC-104, TIDOC-76, TIDOC-210: Rewrote & updated Ti.Map module docs
No description provided.