[TIDOC-399] APIDoc: UI.EmailDialog rewrite #1470
Conversation
|
Please review |
|
Will CR |
| add an attachment to the email. The attachment can either be a Blob or File object. Note: Versions before 1.7.1 will only support one attachment in Android. Since version 1.7.1, our Android implementation will accept multiple attachments, but multiple attachments will only work if the user chooses to send via the Android Gmail app; the Android "Mail" app (which is anyway not available on some handsets) will only accept one attachment from a Titanium app. K9 has also been tested successfully with multiple attachments. | ||
| summary: Adds an attachment. | ||
| description: | | ||
| On Android, since version 1.7.1, multiple attachments may be added, but will only work if |
There was a problem hiding this comment.
Considering that users reading this document will almost certainly not be using 1.7.1 do we need this in here? This is a revision history outside of since, not a description of the API.
|
Docs reviewed, please address comments |
|
Updated. Please review. |
|
Docs reviewed. APPROVED. |
| summary: object of animation properties. pass `animated` property (as boolean) to indicate if the dialog should be animated on open. | ||
| summary: | | ||
| Animation properties. Set `animated` Boolean property to `true` to animate dialog | ||
| on open. | ||
| type: Object |
There was a problem hiding this comment.
open does not take any parameters in android
|
docs reviewed. Had a couple of comments |
|
Updated. Please review. |
|
Code reviewed, left one more comment |
|
Updated. Please review. |
| - name: SENT | ||
| summary: constant for the SENT status result | ||
| summary: Constant for the `SENT` status result. | ||
| description: On Android, this property exists but is not used. | ||
| type: Number | ||
| permission: read-only |
There was a problem hiding this comment.
This is actually reversed. SENT and FAILED used in android. CANCELLED and SAVED are not used. We will also want to remove the [iphone, ipad] tag from CANCELLED and SAVED properties
|
Updated. Please review. |
|
Code reviewed. Request Accepted |
|
Functionally reviewed. Request Accepted |
[TIDOC-399] APIDoc: UI.EmailDialog rewrite
https://jira.appcelerator.org/browse/TIDOC-399