Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[TIMOB-8505] Add support for building local 'jni' resources in android modules #2035

Merged
merged 2 commits into from Apr 26, 2012

Conversation

Projects
None yet
4 participants
Contributor

sptramer commented Apr 19, 2012

Exactly as advertised. Please see the JIRA ticket for testing and resolution information; adding a document to the Android modules guide(s) is part of resolving this issue.

Contributor

billdawson commented Apr 23, 2012

bill reviewing

Contributor

billdawson commented Apr 23, 2012

Works perfectly for V8. For Rhino it's not working (it didn't break anything, since it wasn't working to begin with. :) ) I did some investigation and it turns out our builder.py only looks for native module libs if it's building for V8.

I took mercy on you so you don't need to look at our builder.py. :) Here is a diff to fix the issue.

Now someone else should probably take over the review since I shouldn't review my own code.

Contributor

billdawson commented Apr 23, 2012

One more thing: can you change the sample code (in the TIMOB) to not use the variable name native? Seems like rhino chokes on that.

Contributor

sptramer commented Apr 24, 2012

@billdawson Since pastie went down, can you put the diff on a gist for me?

Contributor

billdawson commented Apr 24, 2012

Contributor

sptramer commented Apr 25, 2012

Changes look clean and FR appropriately. Committing. There should be a new reviewer.

@sptramer sptramer [TIMOB-8505] Integrate builder.py changes to pick up binary libraries…
… when making Rhino runtime builds. Hat tip to Bill Dawson.
aa2aa91
Contributor

joshthecoder commented Apr 26, 2012

Code reviewed and functional tested (Rhino and V8). Accepted

@joshthecoder joshthecoder added a commit that referenced this pull request Apr 26, 2012

@joshthecoder joshthecoder Merge pull request #2035 from sptramer/timob-8505
[TIMOB-8505] Add support for building local 'jni' resources in android modules
2334f16

@joshthecoder joshthecoder merged commit 2334f16 into appcelerator:master Apr 26, 2012

Thanks for doing this; I've been using a patch (linked from http://developer.appcelerator.com/question/133108/why-does-ndkjni-building-no-longer-work-in-182#comment-125008) for this, but I don't know ant well enough to fix it correctly as you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment