New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIDOC-557] Fixed description of horizontal layout. #2110
Conversation
…al other items missed in the 2.0 layout updates.
platform-specific. | ||
|
||
Similar calculations are used for `left` and `right`. | ||
If the child includes a `center.y` value but not a `top` value, the child is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily true...if height is not specified, then the height is calculated from these two values (as mentioned below), but the center does end up at center.y
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Yes, I can see how all of the precedence stuff makes this rather confusing. Let me think about this one.
Docs reviewed for android. Request Accepted |
|
||
This is an input property for specifying the view's height dimension. To determine the view's | ||
size once rendered, see the [size](Titanium.UI.View.size) property. | ||
size once rendered, use the [rect](Titanium.UI.View.rect) or | ||
[size](Titanium.UI.View.size) properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many descriptors for rect
property in the doc. For rect
we have frame, size and position at various places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's the bounding box, which is size + position. But I don't know what 'frame' means, so I'll remove that.
Updated, please review. |
Docs reviewed for IOS. |
@@ -561,6 +556,7 @@ events: | |||
- name: x | |||
summary: X coordinate of the event from the `source` view's coordinate system. | |||
type: Number | |||
since: { android: "2.1.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android doesn't have the twofingertap event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh! I was making sure that format worked before I commented on a couple of community PRs. Got stuck into this commit by accident.
Clarified mobile web 'auto' behavior and removed the rogue 'since' statement.
OK, updated. Please re-review. |
Code re-reviewed. Request accepted (sorry for the delay). |
</tr> | ||
<tr> | ||
<td>`center.y` and `bottom` specified</td><td>Child positioned with center at | ||
`center.y` and bottom edge `bottom` units from parent's bottom. height is determined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'height' should be capitalized here.
Docs reviewed, left minor comments. |
Fixed typos, please re-review. |
Code re-re-reviewed :). Request accepted. |
Code reviewed. ACCEPTED |
Code reviewed and functionally tested. Request Accepted |
[TIDOC-557] Fixed description of horizontal layout.
Also updated several other items missed in the 2.0 layout updates.