timob-1512: fix menu options for windows in tab. #3619

Merged
merged 9 commits into from Jan 19, 2013

Projects

None yet

4 participants

@pingwang2011

Since the implementation of tabgroup is different from before (currently all the tab windows are LW windows while the old tab windows are HW windows), even the "activity" property is exposed to tab windows like this PR does, it won't work the same as before. I suggest an architecture discussion on how to design this API for the current tabgroup.

@pingwang2011 pingwang2011 was assigned Jan 16, 2013
@ghost ghost assigned wluu and ayeung Jan 18, 2013
@ayeung ayeung commented on an outdated diff Jan 18, 2013
...titanium/ui/widget/tabgroup/TiUIAbstractTabGroup.java
import org.appcelerator.titanium.view.TiUIView;
+import ti.modules.titanium.ui.TabContentViewProxy;
@ayeung
ayeung Jan 18, 2013

Remove unused import

@ayeung
ayeung commented Jan 18, 2013

Code reviewed and functionally tested. Looks good. Request Accepted. Will merge after the unused import is removed.

@ayeung ayeung merged commit a508477 into appcelerator:master Jan 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment