TIMOB-4706: Android: Cannot debug an application while using require('some_js_module') #379
Conversation
while in a thread associated with a context. some code cleanup in TitaniumModule. TIMOB-4706
|
Tested with 1.8.0.1761813, no longer encountering crash with debug. Request accepted |
|
Code review and functional test Accepted. Was able to re-create failcase from the JIRA ticket on master, then with this branch there was no failure. |
| // NOTE: commonjs modules load absolute to root in Titanium | ||
| String fileUrl = "app://"+path+".js"; | ||
| // NOTE: CommonJS modules load absolute to app:// in Titanium | ||
| String fileUrl = "app://" + path + ".js"; |
There was a problem hiding this comment.
Should use StringBuilder for more than 1 concat. Also, don't we have a constant for "app://" somewhere?
There was a problem hiding this comment.
Yeah, we have it in constant form -- I'll use that + StringBuilder
…serAgent and require. fixed a class cast exception bug for module exports in the process, thank you unit tests! TIMOB-4706
|
Code re-review and functional re-test Accepted. Functional test via the original failcase in JIRA item, as well as the drillbit tests. |
| // uri is optional but we point it to where we loaded it | ||
| proxy.setProperty("uri",fileUrl); | ||
| return proxy; | ||
| Log.d(LCAT, "Attempting to include JS module: " + tbf.nativePath()); |
There was a problem hiding this comment.
This log statement should be upgraded to INFO or wrapped in if (DBG){}
StringBuilder. TIMOB-4706
… timob-4706 Conflicts: android/titanium/lib/js-debug.jar android/titanium/lib/js.jar
|
Accepted based on another code review and functional test, the latter particularly because Marshall needed to resolve a merge conflict based on a binary file (the js.jar). To be safe I also re-did the functional test of TIMOB-3756 to make sure the merge went "backwards" successfully as well. |
|
Code Reviewed. Request Accepted. |
TIMOB-4706: Android: Cannot debug an application while using require('some_js_module')
http://jira.appcelerator.org/browse/TIMOB-4706
This also has a Rhino component / pull request:
https://github.com/appcelerator/rhino_titanium/pull/3
Repro steps are in the ticket