[TIMOB-12200] Provide profiler data via communication channel #3910

Merged
merged 5 commits into from Mar 8, 2013

Conversation

Projects
None yet
3 participants

@ghost ghost assigned joshthecoder Feb 27, 2013

@mstepanov

This comment has been minimized.

Show comment Hide comment
@mstepanov

mstepanov Feb 27, 2013

Contributor

Please CR/FR, but hold merge until special instruction from Neeraj/Ingo.
Merging https://github.com/appcelerator/titanium_profiler/issues/2 is fine since it's private repo.

Contributor

mstepanov commented Feb 27, 2013

Please CR/FR, but hold merge until special instruction from Neeraj/Ingo.
Merging https://github.com/appcelerator/titanium_profiler/issues/2 is fine since it's private repo.

@@ -150,6 +150,10 @@ static void dispatchHandler()
*/
JNIEXPORT void JNICALL Java_org_appcelerator_kroll_runtime_v8_V8Runtime_nativeInit(JNIEnv *env, jobject self, jboolean useGlobalRefs, jint debuggerPort, jboolean DBG)
{
+ char* argv[] = { "", "--expose-gc" };
+ int argc = sizeof(argv)/sizeof(*argv);
+ V8::SetFlagsFromCommandLine(&argc, argv, false);

This comment has been minimized.

Show comment Hide comment
@joshthecoder

joshthecoder Mar 4, 2013

Contributor

Why do we expose GC?

Also using SetFlagsFromString() would probably be easier. Not sure why you are computing argc that way.

@joshthecoder

joshthecoder Mar 4, 2013

Contributor

Why do we expose GC?

Also using SetFlagsFromString() would probably be easier. Not sure why you are computing argc that way.

This comment has been minimized.

Show comment Hide comment
@mstepanov

mstepanov Mar 4, 2013

Contributor

I could either way.
About argc computing - I hate constants. But sizeof(argv)/sizeof(*argv) has a compile time value of 2.

@mstepanov

mstepanov Mar 4, 2013

Contributor

I could either way.
About argc computing - I hate constants. But sizeof(argv)/sizeof(*argv) has a compile time value of 2.

This comment has been minimized.

Show comment Hide comment
@joshthecoder

joshthecoder Mar 4, 2013

Contributor

Okay.

@joshthecoder

joshthecoder Mar 4, 2013

Contributor

Okay.

@joshthecoder

This comment has been minimized.

Show comment Hide comment
@joshthecoder

joshthecoder Mar 4, 2013

Contributor

CR 👍

Contributor

joshthecoder commented Mar 4, 2013

CR 👍

@ayeung

This comment has been minimized.

Show comment Hide comment
@ayeung

ayeung Mar 5, 2013

Contributor

FR looks good. Request Accepted.

Contributor

ayeung commented Mar 5, 2013

FR looks good. Request Accepted.

@ayeung

This comment has been minimized.

Show comment Hide comment
@ayeung

ayeung Mar 6, 2013

Contributor

Please resolve https://jira.appcelerator.org/browse/TIMOB-12199 when this PR is merged.

Contributor

ayeung commented Mar 6, 2013

Please resolve https://jira.appcelerator.org/browse/TIMOB-12199 when this PR is merged.

ayeung pushed a commit that referenced this pull request Mar 8, 2013

ayeung
Merge pull request #3910 from mstepanov/timob-12200
[TIMOB-12200] Provide profiler data via communication channel

@ayeung ayeung merged commit 88417ac into appcelerator:master Mar 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment