New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-7735] added UITableViewCellEditingStyleInsert iOS API as styleInsert #4636

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Sophrinix
Contributor

Sophrinix commented Aug 31, 2013

I'm more than happy to sign the CLA on this change.
What this does (I'm not sure why the iOS 7 code is there. that isn't part of my intended change) is bring the iOS tableview UITableViewCellEditingStyleInsert API into titanium.

http://blog.codexlabs.com/blog/2013/08/31/uitableviewcelleditingstyleinsert-is-now-a-pull-request-for-titanium-mobile/

If I need to build a sample app and submit that I am more than happy too.

To use this API one would
do
var tableView = Titanium.UI.createTableView({
data: someData,
editable: true,
styleInsert: true,
deleteButtonTitle: 'Delete'
});

I'm not sold on the API because if editable is false then styleInsert is ignored. However, once we (appc and the community) can agree on how the developer API should look, I am more than happy to apply this iOS API on TiUIListView.m

@negupta

This comment has been minimized.

Contributor

negupta commented Feb 19, 2014

Thank you for your commit. We need a ticket associated with each pull request so it can be properly tested. Can you please create one or find one as mentioned in the pull request guide?

@Sophrinix

This comment has been minimized.

Contributor

Sophrinix commented Feb 19, 2014

@Sophrinix

This comment has been minimized.

Contributor

Sophrinix commented Feb 19, 2014

@negupta

This comment has been minimized.

Contributor

negupta commented Feb 19, 2014

Thanks for providing the ticket references. We would take a look.

@hansemannn

This comment has been minimized.

Contributor

hansemannn commented Oct 27, 2015

Hi @Sophrinix , we will support inserting styles in the Titanium Mobile 5.2.0 release.

@hansemannn hansemannn closed this Oct 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment