Timob 6229 Dashboard memory leak cleanup #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,7 +42,7 @@ | |||
| UIButton *badge; | |||
| } | |||
|
|
|||
| @property(nonatomic,readwrite,retain) LauncherItem *item; | |||
| @property(nonatomic,readwrite,assign) LauncherItem *item; | |||
There was a problem hiding this comment.
Does not actually change the assignment semantics of -[LauncherButton setItem:], the code still performs retain/release. Should still reflect the memory management of the setter.
|
Code reviewed. Semantics for prop declarators need to be modified. REJECTED. |
|
Functional tested, iPod 3GT iOS 5.0.1. ACCEPTED pending code review changes (which will not change functional). |
|
Code reviewed. ACCEPTED. |
|
Functional test, iPod 3GT iOS 5.0.1. APPROVED and ACCEPTED. |
sptramer
pushed a commit
that referenced
this pull request
Dec 3, 2011
Timob 6229 Dashboard memory leak cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is in JIRA.