Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25258] Android: Fixed bug where ListView/TableView ignores Ti.UI.SIZE for height. (Introduced in 6.2.0.) #9421

Closed
wants to merge 8 commits into from

Conversation

jquick-axway
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-25258

Notes:

  • This bug was introduced in Titanium 6.2.0 when the RefreshControl feature was added to Android.
  • Issue was caused by Google's "SwipeRefreshLayout" class, which ignores WRAP_CONTENT for height. Modified derived class to support it.

Test:

  1. Run the project attached to TIMOB-25258.
  2. Verify that the displayed table matches ticket's "expected_good.png" screenshot.

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@build
Copy link
Contributor

build commented Sep 20, 2017

Fails
🚫

Tests have failed, see below for more information.

Warnings
⚠️

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code

Tests:

Classname Name Time Error
android.Titanium.UI.View TIMOB-20598 3.2 AssertionError: expected 180 to equal 100
ios.Titanium.UI.View TIMOB-20598 5.005 file:///Users/build/Libra

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

Verified the fix.

Ran the test code in the ticket & the results is as "expected_good.png" screenshot.

Studio Ver: 4.10.0.201709271713
SDK Ver: 7.0.0. local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.4
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.14
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1

@jquick-axway
Copy link
Contributor Author

This fix has been moved to PR #9513 on master. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants