Permalink
Commits on Jun 6, 2010
  1. Fixed: the actual delegate method definition somehow didn't make it i…

    aljungberg authored and Me1000 committed Jun 4, 2010
    …nto the change enabling outlineView:shouldEditTableColumn:item: for outline view inline editing. This commit predefines all CPOutlineView delegate methods.
  2. Don't supress exceptions in the backtrace decorator, add an exception…

    Ross Boucher
    Ross Boucher committed Jun 6, 2010
    … supressing decarator.
  3. Javascript Date object returns month between 0 and 11

    stevegeek authored and Ross Boucher committed Jun 1, 2010
  4. Adding checks for existence of DOM when calling CPPlatformWindow+DOM-…

    saikat authored and Ross Boucher committed Jun 3, 2010
    …only methods
    
    Conflicts:
    
    	AppKit/CPWindow/CPWindow.j
Commits on Jun 5, 2010
  1. Fix for browser:acceptDrop:atRow:column:dropOperation: not being call…

    tolmasky committed Jun 5, 2010
    …ed if browser:validateDrop:proposedRow:column:dropOperation: is implemented.
    
    Reviewed by me.
Commits on Jun 4, 2010
Commits on Jun 3, 2010
Commits on Jun 2, 2010
Commits on Jun 1, 2010
  1. call tableview doubleclick action even if target is nil (action will …

    klaaspieter authored and Me1000 committed Jun 1, 2010
    …travel down the responder chain)
    
    Conflicts:
    
    	AppKit/CPTableView.j
Commits on May 28, 2010
  1. Missing #include had broken the slider color picker.

    Ross Boucher
    Ross Boucher committed May 28, 2010
  2. Minor cleanup to the current test cases.

    Ross Boucher
    Ross Boucher committed May 28, 2010
  3. Merge remote branch 'klaaspieter/bindings-fixes' into bindings

    Ross Boucher
    Ross Boucher committed May 28, 2010
    Conflicts:
    	AppKit/CPControl.j
    	Foundation/CPValueTransformer.j
Commits on May 27, 2010
  1. Fixed a typo in CPObjectController

    Klaas Pieter Annema
    Klaas Pieter Annema committed May 27, 2010
  2. exposed more bindings on CPControl

    Klaas Pieter Annema
    Klaas Pieter Annema committed May 27, 2010
  3. Fixed: [_CPImageAndTextView setDimsImage] wasn't working right due to…

    aljungberg committed May 21, 2010
    … checking if a non existent variable equalled the current value.
Commits on May 26, 2010
  1. Reverse update value binding when control editing stops, not only whe…

    aljungberg committed Mar 14, 2010
    …n the action fires. This causes tabbing out of a text field to update the binding source. Based on the description of the bindings option NSContinuouslyUpdatesValueBindingOption this is the right thing to do: if NSContinuouslyUpdatesValueBindingOption is on, update on every character; "otherwise the update is made only when the user interface item resigns as the responder."
  2. Hack to make [textField bind:CPValueBinding ...] work. Without this, …

    aljungberg committed Mar 12, 2010
    …any observed change leads to a [textField setValue:X forKey:"value"] which in turn leads to a direct ivar access changing the value in textField._value. This means the text field has no idea the value changed and it doesn't update to show the new text. I'm not sure what the right solution should be here. It looks like _replacementKeyPathForBinding should play into this and change the end result to [textField setValue:X forKey:"objectValue"] which would work fine. But currently _replacementKeyPathForBinding applies to the observed key path, not the bound one.
  3. Fixed bindings problems where 'nil' would be transformed into @"". Al…

    aljungberg committed Mar 12, 2010
    …so, CPIsNilTransformerName and its inverse couldn't work because any nil value was immediately returned without transformations being applied. Full complement of unit tests included, based on Cocoa empirical testing.
    
    Fixed with CPKeyValueBinding: the CPValueTransformerNameBindingOption option would cause an exception due a missing import.
  4. The problem with initialize in fb5950c turned out to be caused by a C…

    aljungberg committed Mar 12, 2010
    …appuccino bug with class methods and arguments named 'name'. Renaming the argument solved the problem so I reverted the initialize change. This fix also fixes valueTransformerForName.
  5. Fixed: including CPValueTransformer.j causes an infinite loop due to …

    aljungberg committed Mar 11, 2010
    …the recent Objective-J (mis?) behavior that every class has to inherit from CPObject. Also, the transformer map failed to initialize properly with the existing setup code for reasons which were not immediately clear. Moving the initialization to a regular + initialize method eliminated the problem.
    
    Fixed: CPKeyValueBinding.j would throw an exception if a named value transformer option was specified, due to CPValueTransformer.j not being imported.
  6. Fixed: the array controller remove method mapped selection indexes to…

    aljungberg committed Mar 10, 2010
    … the content array instead of the arranged objects, leading to the wrong objects being removed as filters and sort descriptors were effectively ignored.
  7. Optimized table data loading when using bindings for the cell values.…

    aljungberg committed Feb 15, 2010
    … A special code path in the CPTableColumn's prepareDataView:forRow: method turns a O(n) operation into O(1) where n is the number of items in the model array.
  8. Fixed: the CPArrayController code to remove out of bounds selections …

    aljungberg committed Feb 15, 2010
    …failed to remove the last selected item if the new arrangedObjects array was empty.
  9. Fixed: CPArrayController could get out of bounds selections if a call…

    aljungberg committed Feb 14, 2010
    … to rearrangeObjects caused objects to disappear from the arranged set.
  10. Fixed: CPArrayController would throw out of bounds exceptions when it…

    aljungberg committed Feb 14, 2010
    …s content array was shortened and items at the end were selected.
    
    Extended avoid empty selection support so that when the last item is selected and deleted, the (previously) second to last item is selected instead. Works as expected with multiple selections.
  11. Performance fix: willChange and didChange for CPArrayController's sel…

    aljungberg committed Feb 14, 2010
    …ectionIndexes were sent doubly.
  12. CPArrayController now pushes new selections to the bound model for se…

    aljungberg committed Feb 14, 2010
    …lectionIndexes. Using this, support for selectsInsertedObjects was added.
    
    This commit also fixes a performance problem where calling setSelectionIndexes with a selection equal to the one already active caused a selection update.
  13. Fixed: the CPArrayController addObject: optimization for fast index u…

    aljungberg committed Feb 13, 2010
    …pdates would never fire with a nil _filterPredicate, causing rearrangeObjects to be called needlessly.