Permalink
Browse files

Fix #12048. Set attributes for XML fragments. Close gh-965.

  • Loading branch information...
1 parent 144b8bf commit 2b0e720406c42a4065010ba94e7adb7170ba74c3 Sai Wong committed with dmethvin Oct 15, 2012
Showing with 28 additions and 1 deletion.
  1. +1 −1 src/attributes.js
  2. +1 −0 test/.jshintrc
  3. +15 −0 test/data/testinit.js
  4. +11 −0 test/unit/attributes.js
View
@@ -523,7 +523,7 @@ if ( !getSetAttribute ) {
// Set the existing or create a new attribute node
var ret = elem.getAttributeNode( name );
if ( !ret ) {
- ret = document.createAttribute( name );
+ ret = elem.ownerDocument.createAttribute( name );
elem.setAttributeNode( ret );
}
return ( ret.value = value + "" );
View
@@ -41,6 +41,7 @@
"testIframe": true,
"testIframeWithCallback": true,
"createDashboardXML": true,
+ "createXMLFragment": true,
"moduleTeardown": true,
"testFoo": true,
"foobar": true,
View
@@ -102,6 +102,21 @@ var createWithFriesXML = function() {
return jQuery.parseXML(string);
};
+var createXMLFragment = function() {
+ var xml, frag;
+ if ( window.ActiveXObject ) {
+ xml = new ActiveXObject("msxml2.domdocument");
+ } else {
+ xml = document.implementation.createDocument( "", "", null );
+ }
+
+ if ( xml ) {
+ frag = xml.createElement("data");
+ }
+
+ return frag;
+};
+
var fireNative;
if ( document.createEvent ) {
fireNative = function( node, type ) {
@@ -522,6 +522,17 @@ test( "attr(String, Object) - Loaded via XML document", function() {
equal( titles[ 1 ], "Users", "attr() in XML context: Check second title" );
});
+test( "attr(String, Object) - Loaded via XML fragment", function() {
+ expect( 2 );
+ var frag = createXMLFragment(),
+ $frag = jQuery( frag );
+
+ $frag.attr( "test", "some value" );
+ equal( $frag.attr("test"), "some value", "set attribute" );
+ $frag.attr( "test", null );
+ equal( $frag.attr("test"), undefined, "remove attribute" );
+});
+
test( "attr('tabindex')", function() {
expect( 8 );

0 comments on commit 2b0e720

Please sign in to comment.