Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tweak settings name, screenPoint #218

Merged
merged 3 commits into from Sep 18, 2019

Conversation

@KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Sep 18, 2019

Suggested in https://github.com/appium/appium/pull/13225/files#r324784686

@KazuCocoa KazuCocoa changed the title feat: tweak settings name feat: tweak settings name, screenPoint Sep 18, 2019
NSError *error;
if (![FBScreenPoint.sharedInstance setCoordinatesWithString:(NSString *)[settings objectForKey:SCREEN_POINT]
if (![FBActiveAppDetectionPoint.sharedInstance setCoordinatesWithString:(NSString *)[settings objectForKey:ACTIVE_APP_DETECTION_POINT]
error:&error]) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please apply format to this row

@mykola-mokhnach mykola-mokhnach merged commit c0e31ec into appium:master Sep 18, 2019
2 of 3 checks passed
@KazuCocoa KazuCocoa deleted the km/tweak-settings-name branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants