This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Improve the logic of proxyReqRes method #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Jul 19, 2019
jlipps
reviewed
Jul 22, 2019
| body = util.safeJsonParse(body); | ||
| if (body && body.sessionId) { | ||
| let isResBodyModified = false; | ||
| if (_.has(resBodyObj, 'sessionId')) { |
There was a problem hiding this comment.
could there ever be a situation where resBodyObj is a JSON string rather than an object here?
There was a problem hiding this comment.
isPlainObject check should take care of this
There was a problem hiding this comment.
as for now proxyCommand will always return an object as the second argument
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxyCommandcall already returns an object, so there is no need to perform double conversion there. Also, it only makes sense to call stringily if the body object has been modified to save resources.