Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fingerprint endpoint #324

Merged
merged 5 commits into from Apr 15, 2019
Merged

Add fingerprint endpoint #324

merged 5 commits into from Apr 15, 2019

Conversation

dpgraham
Copy link
Contributor

@dpgraham dpgraham commented Apr 12, 2019

Change list

Add the fingerprint command to the .NET Driver

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Integration tests

  • Have you provided integration tests to pass against the latest version of appium? (for Bugfix or New feature)

public void BeforeAll()
{
var capabilities = Env.ServerIsRemote()
? Caps.GetAndroidCaps(Apps.Get("androidApiDemos"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the condition here has no effect, since both branches are equal

@@ -305,7 +308,7 @@ public Location Location
Execute(AppiumDriverCommand.SetLocation, location.ToDictionary());
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed

@dpgraham dpgraham merged commit 4ec4c8b into master Apr 15, 2019
@dpgraham dpgraham deleted the dpgraham-fingerprint branch April 15, 2019 05:40
laolubenson added a commit that referenced this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants