fix: Fix possible unexpected EPIPE exceptions #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
force-pushed
the
unpipe
branch
from
f66f1f5
to
3812127
Compare
imurchie
approved these changes
Feb 5, 2020
KazuCocoa
approved these changes
Feb 6, 2020
umutuzgur
approved these changes
Feb 9, 2020
umutuzgur
reviewed
Feb 9, 2020
| /** | ||
| * Closes the underlying socket communicating with the phone | ||
| */ | ||
| close () { | ||
| this._socketClient.end(); | ||
| if (!this._socketClient.destroyed) { |
There was a problem hiding this comment.
nit: I usually prefer returning early if a close is no longer necessary
There was a problem hiding this comment.
with return guard it would look like
if (this._socketClient.destroyed) {
return;
}
this._socketClient.end();
which is longer than the current implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://travis-ci.org/appium/appium-xcuitest-driver/jobs/646286301#L4794