fix: use simctl privacy for calendar access #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - osx_image: xcode9.3 | ||
| env: DEVICE=11.3 | ||
|
|
||
| # TODO: uncomment once Travis 9.4 VMs have iOS 11.3 SDK installed | ||
| # - osx_image: xcode9.4 | ||
| # env: DEVICE=11.3 | ||
| - osx_image: xcode9.4 |
There was a problem hiding this comment.
how about adding new environments instead?
There was a problem hiding this comment.
@mykola-mokhnach yeah when I get a chance I'll put in a new PR and port this stuff over to Azure.
mykola-mokhnach
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a call to
xcrun simctl privacy...instead of directly editing TCC.db to grant calendar access.Also changes the simulator.js logic so
simulator-xcode-11.4implementationWHY? So that when Xcode 13 comes out it will, by default, use the latest Xcode implementation. And if it works (ie: our e2e tests keep passing) we don't need to do anything
(depends on appium/node-simctl#114 ... make sure to publish this first and bump up min node-simctl before merging)