Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new remote debugger async execute functionality #1063

Merged
merged 1 commit into from Sep 6, 2019

Conversation

@imurchie
Copy link
Contributor

@imurchie imurchie commented Sep 6, 2019

No description provided.

if (!this.isWebContext()) {
throw new errors.NotImplementedError();
}

return await iosExecuteAsync.call(this, script, args, sessionId);
args = this.convertElementsForAtoms(args);
this.asyncWaitMs = this.asyncWaitMs || 0;
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mutate this value or simply put this.asyncWaitMs || 0 below?

Copy link
Contributor Author

@imurchie imurchie Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 0 if no one has set it, anyway. If it is not there it is a problem and a mistake.

Further, this is the only place it's used, other that setting it. I'm fine with mutating it.

@imurchie imurchie merged commit 5b83568 into master Sep 6, 2019
11 checks passed
@imurchie imurchie deleted the isaac-async-execute branch Sep 6, 2019
khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this issue May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants