Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify '-r' option for video recording #867

Merged
merged 5 commits into from
Feb 6, 2019

Conversation

kolyakrasnik
Copy link
Contributor

The changes for appium/appium#12067

@jsf-clabot
Copy link

jsf-clabot commented Feb 4, 2019

CLA assistant check
All committers have signed the CLA.

@kolyakrasnik
Copy link
Contributor Author

@mykola-mokhnach

@mykola-mokhnach
Copy link
Contributor

Can you please accept the CLA?

@kolyakrasnik
Copy link
Contributor Author

@mykola-mokhnach I signed all agreements but it still shows pending. The issue might be because of other email is associated to this commit. I added both emails to my git account, but it seems to get CLA I need to create a new PR. Should I do that?

@mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach I signed all agreements but it still shows pending. The issue might be because of other email is associated to this commit. I added both emails to my git account, but it seems to get CLA I need to create a new PR. Should I do that?

Try to push a new commit with the updated email. If that does not work then you can create a new PR.

@mykola-mokhnach mykola-mokhnach merged commit 937e7f8 into appium:master Feb 6, 2019
khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants