Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includes mjpegScalingFactor as xcuitest-driver settings #983

Merged
merged 3 commits into from Jun 14, 2019

Conversation

@KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Jun 13, 2019

related to appium/appium#12771

  • DEFAULT_SETTINGS is necessary to prevent the error message so far
  • Set mjpegScalingFactor if it contains in capabilities
  • Add descriptions which can set as capabilities
@mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Jun 13, 2019

I would say this is not needed, since we already have a universal way to set settings from capabilities (using settings[settingName] cap format): appium/appium#12440

@KazuCocoa
Copy link
Member Author

@KazuCocoa KazuCocoa commented Jun 14, 2019

ah, okay. I remember.
Adding the settings in DEFAULT_SETTINGS is needed since the value is used to generate the warning message

@KazuCocoa KazuCocoa force-pushed the km/fix-no-settings-message branch from 81a9489 to 86cc98b Jun 14, 2019
@mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Jun 14, 2019

@imurchie It looks like CI is broken

@imurchie
Copy link
Contributor

@imurchie imurchie commented Jun 14, 2019

@mykola-mokhnach This was an npm problem. I re-ran the unit test in travis, and all the tests in Azure (https://dev.azure.com/AppiumCI/Appium%20CI/_build/results?buildId=3217&view=logs&jobId=0a296736-6346-5e71-5081-8a9c58dece03) and all is well.

@KazuCocoa KazuCocoa merged commit 9fb1efa into appium:master Jun 14, 2019
1 of 8 checks passed
@KazuCocoa KazuCocoa deleted the km/fix-no-settings-message branch Jun 14, 2019
khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this issue May 10, 2021
* includes mjpegScalingFactor as xcuitest-driver settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants