includes mjpegScalingFactor as xcuitest-driver settings #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would say this is not needed, since we already have a universal way to set settings from capabilities (using |
|
ah, okay. I remember. |
KazuCocoa
force-pushed
the
km/fix-no-settings-message
branch
from
81a9489
to
86cc98b
Compare
mykola-mokhnach
approved these changes
Jun 14, 2019
|
@imurchie It looks like CI is broken |
|
@mykola-mokhnach This was an npm problem. I re-ran the unit test in travis, and all the tests in Azure (https://dev.azure.com/AppiumCI/Appium%20CI/_build/results?buildId=3217&view=logs&jobId=0a296736-6346-5e71-5081-8a9c58dece03) and all is well. |
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* includes mjpegScalingFactor as xcuitest-driver settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to appium/appium#12771
DEFAULT_SETTINGSis necessary to prevent the error message so farSetmjpegScalingFactorif it contains in capabilitiesAdd descriptions which can set as capabilities