Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support other apps ios #988

Merged
merged 4 commits into from Jul 24, 2019
Merged

Conversation

vrunoa
Copy link
Contributor

@vrunoa vrunoa commented Jun 19, 2019

[work in progress]
Something that came up in appium conf is giving support for otherApps capability on iOS. Gonna add a functional test to make sure it works.

lib/driver.js Outdated Show resolved Hide resolved
lib/desired-caps.js Show resolved Hide resolved
lib/driver.js Outdated Show resolved Hide resolved
Copy link
Contributor

@imurchie imurchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

lib/utils.js Outdated Show resolved Hide resolved
lib/driver.js Outdated Show resolved Hide resolved
lib/driver.js Outdated Show resolved Hide resolved
@mykola-mokhnach
Copy link
Contributor

@vrunoa Any updates on this PR?

@KazuCocoa
Copy link
Member

ping @vrunoa
Can I assist this PR?

@vrunoa
Copy link
Contributor Author

vrunoa commented Jul 17, 2019

@mykola-mokhnach @KazuCocoa sorry for the delay, working on it. I added a few changes to integrate appium-base-driver parseCapsArray. Can you guys take a look at this PR, merge it and publish a new version so I can update the appium-base-driver here?
appium/appium-base-driver#333

@vrunoa vrunoa changed the title Add support other apps ios WIP: Add support other apps ios Jul 17, 2019
@KazuCocoa
Copy link
Member

appium/appium-base-driver#333 is available as 3.18.0

@vrunoa vrunoa changed the title WIP: Add support other apps ios Add support other apps ios Jul 21, 2019
add parseArray

add new capability for otherApps

add possibility to install otherApps on simulators

add parseArray method

moving install other apps to it's own method

add functional test to verify multiple apps are installed

add capabilities for otherApps

remove tests for parseCapsArray, this was moved to appium-base-driver

update docs

update appium-base-driver version

remove parseArray

add unit tests

remove testing e2e test
@vrunoa vrunoa force-pushed the add-support-otherApps-ios branch from efda070 to cb3c891 Compare July 21, 2019 01:46
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments, otherwise lgtm.

lib/driver.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/functional/driver/otherApps-e2e-specs.js Show resolved Hide resolved
test/unit/driver-specs.js Show resolved Hide resolved
@vrunoa vrunoa changed the title Add support other apps ios WIP: Add support other apps ios Jul 21, 2019
@vrunoa vrunoa changed the title WIP: Add support other apps ios Add support other apps ios Jul 21, 2019
@KazuCocoa KazuCocoa merged commit f724910 into appium:master Jul 24, 2019
khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this pull request May 10, 2021
* Add otherApps capability

add parseArray

add new capability for otherApps

add possibility to install otherApps on simulators

add parseArray method

moving install other apps to it's own method

add functional test to verify multiple apps are installed

add capabilities for otherApps

remove tests for parseCapsArray, this was moved to appium-base-driver

update docs

update appium-base-driver version

remove parseArray

add unit tests

remove testing e2e test

* rollback package dependencies

* add otherApps example using json array as string

* use const instead of let
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants