Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove using iproxy #996

Merged
merged 7 commits into from Jul 2, 2019
Merged

feat: remove using iproxy #996

merged 7 commits into from Jul 2, 2019

Conversation

@umutuzgur
Copy link
Member

@umutuzgur umutuzgur commented Jun 29, 2019

Remove iproxy and use a native implementation for port forwarding

@umutuzgur umutuzgur requested a review from mykola-mokhnach Jun 29, 2019
lib/wda/iproxy.js Outdated Show resolved Hide resolved
lib/wda/iproxy.js Outdated Show resolved Hide resolved
lib/wda/iproxy.js Outdated Show resolved Hide resolved
lib/wda/iproxy.js Outdated Show resolved Hide resolved
lib/wda/iproxy.js Outdated Show resolved Hide resolved
@umutuzgur umutuzgur marked this pull request as ready for review Jul 1, 2019
@@ -333,12 +333,7 @@ class WebDriverAgent {
}

set fullyStarted (started = false) {
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need the fullyStarted concept?

Copy link
Member Author

@umutuzgur umutuzgur Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the purpose of this originally?

Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imurchie has to know ;)

@umutuzgur umutuzgur requested a review from imurchie Jul 1, 2019
lib/wda/iproxy.js Outdated Show resolved Hide resolved
!cmdLine.toLowerCase().includes(this.device.udid.toLowerCase()));

if (this.realDevice) {
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if iproxy.quit was not called before and we try to start a new session? Is there a possibility to stop the "third party" socket listener?

Copy link
Member Author

@umutuzgur umutuzgur Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that is necessary. I'm not a big fan cleaning old stuff

Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if something like that happens then it might be impossible to start a new session unless one kills Appium process completely

Copy link
Member Author

@umutuzgur umutuzgur Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked in person and came to a conclusion

jlipps
jlipps approved these changes Jul 1, 2019
@umutuzgur umutuzgur merged commit f04879c into master Jul 2, 2019
8 of 10 checks passed
@umutuzgur umutuzgur deleted the remove_iproxy branch Jul 2, 2019
createIProxy () {
const iproxy = new iProxy(this.device.udid, this.url.port, WDA_AGENT_PORT);
try {
iproxy.start();
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start could return iproxy instance

@artemryazantsev
Copy link

@artemryazantsev artemryazantsev commented Oct 1, 2019

@umutuzgur @mykola-mokhnach hello guys, can you please clarify what is a 'native' implementation for port forwarding for now? You just integrated iproxy library somewhere in appium sources or you start using something different? thanks in advance

@umutuzgur
Copy link
Member Author

@umutuzgur umutuzgur commented Oct 1, 2019

@artemryazantsev We now use a full nodejs library to do the iOS operations. This also includes iproxy. It is in nodejs now and you can find the library at https://github.com/appium/appium-ios-device

@artemryazantsev
Copy link

@artemryazantsev artemryazantsev commented Oct 1, 2019

@umutuzgur thank you for quick response

khanayan123 pushed a commit to khanayan123/appium-xcuitest-driver that referenced this issue May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants