feat: remove using iproxy #996
Conversation
| @@ -333,12 +333,7 @@ class WebDriverAgent { | |||
| } | |||
|
|
|||
| set fullyStarted (started = false) { | |||
There was a problem hiding this comment.
do we still need the fullyStarted concept?
There was a problem hiding this comment.
What was the purpose of this originally?
There was a problem hiding this comment.
@imurchie has to know ;)
| !cmdLine.toLowerCase().includes(this.device.udid.toLowerCase())); | ||
|
|
||
| if (this.realDevice) { |
There was a problem hiding this comment.
What happens if iproxy.quit was not called before and we try to start a new session? Is there a possibility to stop the "third party" socket listener?
There was a problem hiding this comment.
Do you think that is necessary. I'm not a big fan cleaning old stuff
There was a problem hiding this comment.
if something like that happens then it might be impossible to start a new session unless one kills Appium process completely
There was a problem hiding this comment.
Talked in person and came to a conclusion
| createIProxy () { | ||
| const iproxy = new iProxy(this.device.udid, this.url.port, WDA_AGENT_PORT); | ||
| try { | ||
| iproxy.start(); |
There was a problem hiding this comment.
start could return iproxy instance
|
@umutuzgur @mykola-mokhnach hello guys, can you please clarify what is a 'native' implementation for port forwarding for now? You just integrated iproxy library somewhere in appium sources or you start using something different? thanks in advance |
|
@artemryazantsev We now use a full nodejs library to do the iOS operations. This also includes iproxy. It is in nodejs now and you can find the library at https://github.com/appium/appium-ios-device |
|
@umutuzgur thank you for quick response |
Remove iproxy and use a native implementation for port forwarding