Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mark launch app and close app as false for espresso driver #13092

Merged

Conversation

KazuCocoa
Copy link
Member

Proposed changes

Related to appium/appium-espresso-driver#485

Espresso driver can test only one app which is specified as capabilities.
Launch and Close app mean starting the espresso session and delete it.
Thus, in appium/appium-espresso-driver#485, I've changed to show an error message to use create/delete session instead of launch/close app. (Existed aunch/close app was broken partially, btw.)

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.893% when pulling ada0977 on KazuCocoa:km/make-launch-close-all-false-espresso into 15a23b8 on appium:master.

@imurchie imurchie merged commit 5d05313 into appium:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants