Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add `brew install appium` option #13363

Open
wants to merge 1 commit into
base: master
from

Conversation

@chenrui333
Copy link

commented Oct 4, 2019

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Relates to Homebrew/homebrew-core#44607

Good to have brew to help with the appium installation. :)

@coveralls

This comment has been minimized.

Copy link

commented Oct 4, 2019

Coverage Status

Coverage remained the same at 89.391% when pulling 4e0a71c on chenrui333:add-brew-install-option into a74c299 on appium:master.

@mykola-mokhnach

This comment has been minimized.

Copy link
Collaborator

commented Oct 7, 2019

We don't officially support brew, but npm. So we cannot guarantee the package retrieved from brew is functional or rather accept any issues related to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.