Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only catch signals once #7648

Merged
merged 1 commit into from Jan 5, 2017
Merged

Only catch signals once #7648

merged 1 commit into from Jan 5, 2017

Conversation

imurchie
Copy link
Contributor

@imurchie imurchie commented Jan 5, 2017

Proposed changes

Currently we catch every SIGINT and SIGTERM signal coming in and try to stop the http server. Unfortunately, if there are connections, it has to wait for them to be closed on both ends before Appium actually stops.

This is a quick solution, only adding a one-time event listener for the signals. So if someone cares that the connections are closed etc. they can wait, otherwise another signal will terminate the whole thing.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Reviewers: @jlipps

@imurchie
Copy link
Contributor Author

imurchie commented Jan 5, 2017

See #7328

@jmehtaebates
Copy link

See #7644

Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huzzah, this is much better behavior!

@imurchie imurchie merged commit d825a17 into master Jan 5, 2017
@imurchie imurchie deleted the isaac-stop branch January 5, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants