New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write W3C capabilities into firstMatch entity instead of alwaysMatch #1010

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
3 participants
@mykola-mokhnach
Copy link
Contributor

mykola-mokhnach commented Aug 28, 2018

Change list

Just did the same what Selenium is already doing: https://github.com/SeleniumHQ/selenium/blob/479a801b39efa53966e35eec0bae55ca0bcc02da/java/client/src/org/openqa/selenium/remote/NewSessionPayload.java#L252

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
@KazuCocoa
Copy link
Member

KazuCocoa left a comment

The change looks 👍
I'll work for Ruby and Python. appium/ruby_lib_core#137
(Python has the same issue in selenium, I guess... Anyway, I'll take a look)

@mykola-mokhnach mykola-mokhnach merged commit 421d03b into appium:master Aug 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@mykola-mokhnach mykola-mokhnach deleted the mykola-mokhnach:first_match branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment