From 0fde5a4bd9dbec465d550eb2c6ebfcd55e1c7482 Mon Sep 17 00:00:00 2001 From: Kazuaki Matsuo Date: Tue, 1 Nov 2022 01:57:17 -0700 Subject: [PATCH 1/2] chore: use Lambok --- .../java_client/remote/DirectConnect.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/java/io/appium/java_client/remote/DirectConnect.java b/src/main/java/io/appium/java_client/remote/DirectConnect.java index a2049c589..de66fb42f 100644 --- a/src/main/java/io/appium/java_client/remote/DirectConnect.java +++ b/src/main/java/io/appium/java_client/remote/DirectConnect.java @@ -1,5 +1,9 @@ package io.appium.java_client.remote; +import lombok.AccessLevel; +import lombok.Getter; +import lombok.experimental.Accessors; + import javax.annotation.Nullable; import java.net.MalformedURLException; import java.net.URL; @@ -9,20 +13,20 @@ import static io.appium.java_client.internal.CapabilityHelpers.APPIUM_PREFIX; -// TODO: simplify with lombok as another PR +@Accessors(fluent = false, chain = false) public class DirectConnect { private static final String DIRECT_CONNECT_PROTOCOL = "directConnectProtocol"; private static final String DIRECT_CONNECT_PATH = "directConnectPath"; private static final String DIRECT_CONNECT_HOST = "directConnectHost"; private static final String DIRECT_CONNECT_PORT = "directConnectPort"; - private final String protocol; + @Getter(AccessLevel.PUBLIC) private final String protocol; - private final String path; + @Getter(AccessLevel.PUBLIC) private final String path; - private final String host; + @Getter(AccessLevel.PUBLIC) private final String host; - private final String port; + @Getter(AccessLevel.PUBLIC) private final String port; /** * Create a DirectConnect instance. @@ -35,10 +39,6 @@ public DirectConnect(Map responseValue) { this.port = this.getDirectConnectValue(responseValue, DIRECT_CONNECT_PORT); } - public String getProtocol() { - return protocol; - } - @Nullable private String getDirectConnectValue(Map responseValue, String key) { Object directConnectPath = responseValue.get(APPIUM_PREFIX + key); From 000fb8c6432640666b02b90af7e1aabf0728dbe4 Mon Sep 17 00:00:00 2001 From: Kazuaki Matsuo Date: Tue, 1 Nov 2022 09:45:20 -0700 Subject: [PATCH 2/2] Update src/main/java/io/appium/java_client/remote/DirectConnect.java Co-authored-by: Valery Yatsynovich --- src/main/java/io/appium/java_client/remote/DirectConnect.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/io/appium/java_client/remote/DirectConnect.java b/src/main/java/io/appium/java_client/remote/DirectConnect.java index de66fb42f..bfd0f4129 100644 --- a/src/main/java/io/appium/java_client/remote/DirectConnect.java +++ b/src/main/java/io/appium/java_client/remote/DirectConnect.java @@ -13,7 +13,7 @@ import static io.appium.java_client.internal.CapabilityHelpers.APPIUM_PREFIX; -@Accessors(fluent = false, chain = false) +@Accessors public class DirectConnect { private static final String DIRECT_CONNECT_PROTOCOL = "directConnectProtocol"; private static final String DIRECT_CONNECT_PATH = "directConnectPath";