From 52bc89df96711e9bff7354fcb10352926c7929f8 Mon Sep 17 00:00:00 2001 From: Valery Yatsynovich Date: Wed, 25 Jan 2023 19:28:31 +0300 Subject: [PATCH] perf: Improve performance of proxy `Interceptor` logging --- .../io/appium/java_client/proxy/Interceptor.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/io/appium/java_client/proxy/Interceptor.java b/src/main/java/io/appium/java_client/proxy/Interceptor.java index 921b86124..d343fc9c1 100644 --- a/src/main/java/io/appium/java_client/proxy/Interceptor.java +++ b/src/main/java/io/appium/java_client/proxy/Interceptor.java @@ -72,10 +72,10 @@ public static Object intercept( } catch (NotImplementedException e) { // ignore } catch (Exception e) { - logger.error( - String.format("Got an unexpected error in beforeCall listener of %s.%s method", - self.getClass().getName(), method.getName()), e - ); + logger.atError() + .addArgument(() -> self.getClass().getName()) + .addArgument(method::getName) + .log("Got an unexpected error in beforeCall listener of {}.{} method", e); } }); @@ -118,10 +118,10 @@ public static Object intercept( } catch (NotImplementedException e) { // ignore } catch (Exception e) { - logger.error( - String.format("Got an unexpected error in afterCall listener of %s.%s method", - self.getClass().getName(), method.getName()), e - ); + logger.atError() + .addArgument(() -> self.getClass().getName()) + .addArgument(method::getName) + .log("Got an unexpected error in afterCall listener of {}.{} method", e); } }); return endResult;