From 9d72771deadba2a2558127c2bedb4985a3e4ec9a Mon Sep 17 00:00:00 2001 From: Kazuaki MATSUO Date: Sat, 16 Dec 2017 11:38:17 +0900 Subject: [PATCH 1/2] fix creating sessions --- lib/appium_lib_core/common/base/bridge.rb | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/lib/appium_lib_core/common/base/bridge.rb b/lib/appium_lib_core/common/base/bridge.rb index 0cc787e2..9fb50d78 100644 --- a/lib/appium_lib_core/common/base/bridge.rb +++ b/lib/appium_lib_core/common/base/bridge.rb @@ -24,6 +24,19 @@ def self.handshake(**opts) raise CoreError, 'cannot understand dialect' end end + + private + + # Use capabilities directory because Appium's capability is based on W3C one. + # Called in bridge.create_session(desired_capabilities) + def merged_capabilities(desired_capabilities) + { + desiredCapabilities: desired_capabilities, + capabilities: { + firstMatch: [desired_capabilities] + } + } + end end # class Bridge class CoreBridgeMJSONWP < ::Selenium::WebDriver::Remote::OSS::Bridge From 2216de2ad940f88fd8af3b99cd2a7e2f669b4f29 Mon Sep 17 00:00:00 2001 From: Kazuaki MATSUO Date: Sat, 16 Dec 2017 12:08:52 +0900 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3bcfb7d2..654ae569 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file. - session/:session_id/appium/device/keyevent [#21](https://github.com/appium/ruby_lib_core/issues/21) ### Bug fixes +- fix creating sessions [#31](https://github.com/appium/ruby_lib_core/pull/31) for W3C creating sessions ### Deprecations